Download & Extend

Extra space added before the comma that separates multiple office hour periods

Project:Office Hours
Version:7.x-1.x-dev
Component:Code
Category:bug report
Priority:minor
Assigned:Lunk Rat
Status:closed (fixed)

Issue Summary

I noticed that multiple office hour periods have a space before and after the comma, like this:

Monday: 1:00 AM - 2:00 AM , 3:00 AM - 4:00 AM

But I think most people would want it formatted like this:

Monday: 1:00 AM - 2:00 AM, 3:00 AM - 4:00 AM

I fixed it by editing office_hours.theme.inc line 73, changing from this:

        $additional = ' , <span class="oh-display-hours">' . $strhrs2 . ' - ' . $endhrs2 . '</span>';

To this:

        $additional = ', <span class="oh-display-hours">' . $strhrs2 . ' - ' . $endhrs2 . '</span>';

I would submit a patch but I need to learn how to create one. I will git going on that one of these days . . .

Comments

#1

Status:needs review» postponed (maintainer needs more info)

Can you please try this patch #1244960: New formatter (inline vs. tabular) + more settings per formatter (day notation, separator) , and report back if it is satisfactory?
It allows you to change the appearance of the formatter ANY way you like.

#2

I'm sorry I can't get any of those patches to apply.

#3

Status:postponed (maintainer needs more info)» fixed

The patch as in #2 is now committed. Now you can change any detail of your formatter.

#4

Status:fixed» closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

nobody click here