Needs review
Project:
PHPlist Integration Module
Version:
7.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
2 Dec 2011 at 11:06 UTC
Updated:
2 Apr 2012 at 18:57 UTC
Jump to comment: Most recent file
Comments
Comment #1
liliplanet commentedthis happens even on a vanilla installation (:
have rebuilt the phplist server, new drupal installation, tried all, yet still this error unfortunately
error on saving user and on user/register otherwise looking very good!
see attached and thank you Paul :)
Comment #2
drupalycious commentedHello,
I obtain the same error message, but it doesn't seem to be a real bug as this message appears when the users I am trying to synchronize are already in the phplist database.
Then this message appears also when the synchronisation to PHPlist is completed.
It is as if the programme runs a last check and sees no body else to add and reacts by giving this error.
Comment #3
drupalycious commentedHi Paul,
this error message appears each time a user updates any data in his/her account (password, email,...).
It is quite annoying. But the module works as expected so far.
Will you try to fix it? Is this module still actively maintained?
thanks
Comment #4
liliplanet commentedThis is such an important module, but I think it has been abandoned. Prepared to chipin to have this fixed please ..
Comment #5
drupalycious commentedTrue it is an important modules for websites with newsletters and users registered.
So far only phplist gives the option to send a certain amount of messages per hour and per domain name, preventing that your domain name is not flagged as a spammer.
I found a workaround that can be used until this gets fixed by Paul or a new maintainer:
to avoid that your end users see the error messages, just install the module Disable Messages,
go to the permissions page and disable the permission to see the error and warning messages to all the users' roles but the administrator.
Leave the permission to see "status messages" so that the end users still see messages like "log in successful" or "changes have been done".
Comment #6
paulbeaney commentedHi Lilian, sp-drupy (and anyone else who was wondering where on earth I was...),
Really sorry to have been silent so long. I have had 2 massive projects on the go for a while now, and along with the web sites that I maintain on a voluntary basis, I simply haven't had the time to invest any more in this module - especially as none of my clients now use it (I have developed a module for EmailVIsion which I will soon be contributing, if anyone is tempted to jump ship!)
I have just made a change to the dev version to address the problem raised in this bug report. Please can you try it out and confirm that it works ok? I'm afraid I am going to be abandoning this module from now on. I just hope someone else will step up to the line.
Regards,
- Paul
Comment #7
paulbeaney commented[Changed status]
Comment #8
drupalycious commentedHi Paul,
thank you for trying to fix this.
Are you sure you uploaded the new 7.x dev version, in the project page it is still mentioned as to be the one from September 2011?
Nevertheless I tested this dev version again and try to modify my password and the same error message is still being shown after the changes are saved.
Comment #9
ajeancharles commentedPractice Defensive Coding!
The code need to be tightened up. Given the number of modules interacting with each other, before you get a value from an associative array, you need to test whether or not the a value has been set,
e.g., do
$node->phplistbackend_status = isset($message['status'])? $message['status'] : "";instead of
$node->phplistbackend_status = $message['status'] ;do
$node->phplistbackend_sendstart = isset($message['sendstart']) ? $message['sendstart'] : "";
instead of
$node->phplistbackend_sendstart = $message['sendstart'] ;