For code readability and forward compatibility, all instances of $_GET['q'] should be replaced with the current_path() API function. The attached text file shows all files and line numbers of $_GET['q'] references in Facet API.

CommentFileSizeAuthor
#1 facetapi-1359376-1.patch4.12 KBfoopang
get-q-instances.txt961 bytescpliakas

Comments

foopang’s picture

foopang commented
Component: Code (functionality) » Code
StatusFileSize
new facetapi-1359376-1.patch4.12 KB

Hi, this is my first attempt, please review it. Thanks so much!

cpliakas’s picture

cpliakas commented
Status: Active » Needs review

Thanks for the patch! Minor procedural point, make sure to mark the issue as "needs review" so it shows up in the appropriate queue.

Appreciate the contribution!
~Chris

cpliakas’s picture

cpliakas commented
Status: Needs review » Reviewed & tested by the community

Looks good to me. All instances of $_GET['q'] have been replaced, patch applies cleanly. Marking as RTBC.

nick_vh’s picture

nick_vh
he/him
Location Ghent
commented

+1 from me ;-)

cpliakas’s picture

cpliakas commented
Status: Reviewed & tested by the community » Fixed

Thanks for the second set of eyes, Nick. Committed at 66b3840.

beansboxchrispang, congrats on becoming the 15th committer to Facet API!

foopang’s picture

foopang commented

Thanks Chris, really happy that I could ever contribute to such a great module, although it is just some very minor editing:)

Automatically closed -- issue fixed for 2 weeks with no activity.