Sometimes, _provision_civicrm_is_site_context() gives php errors for sites on non-civicrm platforms

Alright, here's a patch to at least make operations possible.

*However* I suspect that this is only symptomatic of a larger problem regarding Drupal 7 support (why else would we try to check an unexisting index?).

Thanks for the patch, but did you determine exactly how to reproduce the bug?

Reproducing the bug: Clone a Drupal 7 site which is on a platform that does not include CiviCRM. The task fails.

About the patch: I think it's causing some problems with Drupal 6 CiviCRM platforms. It might be necessary to get to the root of the problem.

I'm having a hard time reproducing the issue with new sites and platforms.

Here's what we're using anyway:

• Those makefiles: http://drupal.org/project/kplatforms
• Drush 4.4 and Drush Make 2.3
• The standard Aegir debian package (version 1.5-2)
• The latest commit in the 6.x-1.x branch of provision_civicrm (nov 28)

To give you an idea of the situation:

• We are using kplatforms to build the platforms (http://drupal.org/project/kplatforms)
• All problematic sites are on a platform built with the 2011-10-27 version of the kplatforms makefiles
• Trying to clone the sites anywhere fails (same undefined index error)
• Trying to migrate the sites to a more recent platform (2011-12-01) fails (same error)
• Most sites have passed. I can't yet identify what those particular sites have in common that other sites don't.
• I can't reproduce the bug on more recent platforms. Though again not all sites failed to migrate from the

old one to the new, so I might have simply missed it.

I guess it's not much, but the problem persists. I'll probably have more info after the next upgrade.

I managed to reproduce this bug, since Aegir 1.8, it seems on a related issue #1545652: _provision_civicrm_is_site_context fails to detect CiviCRM.

Doing an isset($packages['modules']) seems to do the trick. Patched in 6.x-1.x.