Minor html bug in page.tpl.php

Looking at the patch, you are removing a ul, not an h2?

typo error

seven_minor_html_error.patch queued for re-testing.

This markup change is not backportable to D7. However, let's confirm the fix in D8. Please test the patch manually and provide:

• Before-and-after markup in the seven theme where secondary tasks are set.
• Before-and-after screenshots.

The patch for D8 in #1 applied cleanly with an offset and removed the duplicate <ul class="tabs secondary"></ul>.

I'm not sure why this change couldn't be backported to D7 since it is invalid markup (W3.org displays 2 errors) and, since it is simply presenting a duplicate <ul class="tabs secondary">, the possible CSS targeting the invalid markup would be something like:

• .tabs .tabs
• .secondary .secondary
• .tabs-secondary ul ul

which, IMO, seem unlikely to be used.

Looks good. Committed/pushed to 8.x.

Moving to 7.x to discuss backport some more, it looks like just a straight error to me so I think it might be OK.

The same patch for D7 (the one in the original issue didn't apply properly).

Reviewed and tested.

Yeah, I think this is OK for backport given that the nested <ul> tags are completely broken HTML.

I suppose it could cause problems for someone doing something unusual with the rendering (e.g., overriding theme_menu_local_tasks() to use different classes but then still having CSS around which references the old classes), but that seems pretty unlikely. Also, since Seven is primarily used on admin pages only, I think we can be more lenient with changing its HTML.

So... committed to 7.x - thanks! http://drupalcode.org/project/drupal.git/commit/8773e7f (with a mention in CHANGELOG.txt, and this will also be mentioned in the release notes, given that it's a markup change)

Drupal 7.16 was a security release only, so this issue is now scheduled for Drupal 7.17 instead.

Fixing tags accordingly.

typo error