All popup IFRAMEs are created with attribute scrolling="no". If the content inside the IFRAME is "bigger" than the actual modal view (in it's maximum size), user should be able to scroll the content. This works properly in Firefox for instance but Chrome ignores the overflow-y:scroll CSS and disables scrolling of the IFRAME. There are possible CSS fixes available but none work nicely in all browsers.

Suggested fix is to set scrolling attribute to 'auto' as it's the default state and only explicitly set to 'no'.

CommentFileSizeAuthor
#9 without_patch.png264.39 KBdevin carlson
#9 with_patch.png266.63 KBdevin carlson
#1 media-scrolling-issue-1359524-2.patch580 bytespeterpajchl

Comments

peterpajchl’s picture

peterpajchl commented
StatusFileSize
new media-scrolling-issue-1359524-2.patch580 bytes

Enclosed patch sets IFRAME scrolling attribute defaults to 'auto'.

peterpajchl’s picture

peterpajchl commented
Status: Active » Needs review

Setting to "needs review"

dddave’s picture

dddave commented
Version: 7.x-2.0-unstable2 » 7.x-2.x-dev

Still relevant?

dddave’s picture

dddave commented

#1: media-scrolling-issue-1359524-2.patch queued for re-testing.

dddave’s picture

dddave commented

@DaveReid or somebody who is in the know:

Do we still need this?

MPetrovic’s picture

MPetrovic commented

Yes, it's still relevant. I have 2 rows of items in my View and can't see the submit button without holding the middle mouse button down and dragging.

dddave’s picture

dddave commented

You can speed up the process if you could test the patch and post your findings here. ;)

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented

I'm having a problem duplicating this condition in Chrome. If I increased the pager limit for the Media browser view to 50, the dialog still sizes it's height correctly so that I don't have to scroll.

devin carlson’s picture

devin carlson commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new with_patch.png266.63 KB
new without_patch.png264.39 KB

I've tested this with a number of themes and, depending on how they style things like exposed views filters, the buttons can be pushed off of the page and require a middle mouse button click to scroll to.

This patch guarantees that users will still be able to use the buttons regardless of which administrative theme they are using. It would also enable the extra "scrollbox" div on the library tab to be removed.

The patch applied cleanly with an offset. I've attached an image showing how the buttons can be hidden (using bartik as an example) and how the patch enables the iframe to be scrolled so the buttons can be reached.

I think that this is the best option, short of removing the ability to select a custom administration theme.

devin carlson’s picture

devin carlson commented

Marked #1489690: media browser layout broken in Bartik as a duplicate.

devin carlson’s picture

devin carlson commented

Marked #1490816: Media browser plus modal window height as a duplicate.

devin carlson’s picture

devin carlson commented

Marked #1445994: risks of hidden overflow in modal popups as a duplicate.

drzraf’s picture

drzraf commented

tested the patch, the above bug is not a duplicate

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
Status: Reviewed & tested by the community » Fixed

Committed #1 to Git.
http://drupalcode.org/project/media.git/commit/5aaa570
http://drupalcode.org/project/media.git/commit/a581786

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

rfiertek’s picture

rfiertek commented

HI,

Anyone have an idea how I could patch Drupal 6.x, where the proper js file is located?

Thanks,
Robert