Drupal 7.9 - OpenPublish 7.x-1.0.2
nginx Barracuda/1.0.10
PHP 5.2.17
Aegir

I was running into issues with the OpenPublish apps installer which uses the update module. My use case and errors are listed in this issue: Installing Disqus "app" - AJAX HTTP error

However, once I hacked OpenPublish to work, I realized there were other errors occurring in the update.manager.inc. Some functions in update.manager.inc were calling _update_manager_XXX helper functions that weren't available but live in the update.module file. In particular the update_manager_file_get() function calls _update_manager_cache_directory() but that helper function isn't loaded from upload.module.

I will attach a patch that is my attempt to move these helper functions to the upload.manager.inc and adjusts the upload.module to load them only when necessary. Hopefully this makes sense.

CommentFileSizeAuthor
#4 update_helper_functions-1359550-4.patch4.51 KBdooug
#1 update_helper_functions-1359550-1.patch4.45 KBdooug

Comments

dooug’s picture

dooug commented
StatusFileSize
new update_helper_functions-1359550-1.patch4.45 KB

Attached is a patch to update.module and update.manager.module to resolve error of calling unloaded functions.

dooug’s picture

dooug commented
Title: Upload module calling un-loaded functions - causing errors » Update module calling un-loaded functions - causing errors

fixed typo in title

artis’s picture

artis commented

I'm experiencing this same issue on Drupal 7.10

dooug’s picture

dooug commented
Version: 7.9 » 7.x-dev
Status: Needs work » Needs review
StatusFileSize
new update_helper_functions-1359550-4.patch4.51 KB

I double checked my earlier patch and I accidentally had it reversed. I re-rolled it onto the latest 7.x-dev. Please review.

@artis, can you test/review the patch?

Status: Needs review » Closed (outdated)

Automatically closed because Drupal 7 security and bugfix support has ended as of 5 January 2025. If the issue verifiably applies to later versions, please reopen with details and update the version.