ensure_result is documented as defaulting to TRUE, but it doesn't [#1359694]

Comment	File	Size	Author
#3	default-options-1359694-3.patch	3.05 KB	gielfeldt
#1	1359694.1-default-options.patch	960 bytes	deviantintegral

deviantintegral commented 2 December 2011 at 21:12

Assigned:	deviantintegral	» Unassigned
Status:	Active	» Needs review

Status	File	Size
new	1359694.1-default-options.patch	960 bytes

gielfeldt commented 2 December 2011 at 21:42

Thanks.

Isn't it more common practice in this case to do:
$options += $defaults;

instead of:
$options = array_merge($defaults, $options);

?

gielfeldt commented 3 December 2011 at 16:07

Status	File	Size
new	default-options-1359694-3.patch	3.05 KB

How about this? I've also changed the strange way I was handling default options in cache_graceful_execute().

gielfeldt commented 17 December 2011 at 05:44

Status:

Needs review

» Fixed

Committed to dev

31 December 2011 at 05:50

Status:

Fixed

» Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

ensure_result is documented as defaulting to TRUE, but it doesn't