Hi,

I found two bugs in this module.
1. in select country section: Didn't showed Hungary option, and the Poland and Netherland options were in wrong rows.
2. The format function did generated error message, because four matches are unnecessary.

I attached the patch, that solve this problem.

Please review, and if it work, you can use it.

Thanks,
Lohn Dániel

CommentFileSizeAuthor
country_settings.patch993 byteslohndaniel

Comments

dpovshed’s picture

Hi Lohn,
I tested your patch against latest dev version and it seems fine with me.

The patch fixed exactly these problems as you described, so I vote for this small fix.

g1smd’s picture

I've taken care of the phone.hu.inc change along with several others within the phone.hu.inc file inside another patch.

slcp’s picture

@g1smd - Please reference the issue where this patch can be found (like this [#issue-number]) and the close this as duplicate if appropriate.

Alternatively you may need to break down your patch into multiple patches to address different issues if it is outside the scope of the issue it is already attached to...just trying to cover all bases :o)

g1smd’s picture

I'm waiting for the module owner to re-appear before devoting any more time to this module.

I have a large number of patches already prepared but not yet uploaded.

rfsbsb’s picture

Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.