Download & Extend

ajax comments are broken

Project:Heartbeat
Version:7.x-1.x-dev
Component:Miscellaneous
Category:bug report
Priority:normal
Assigned:muschpusch
Status:closed (fixed)

Issue Summary

Me again.... Ajax comments are broken due to depreciated function drupal_json in D7. See the patch!

AttachmentSize
fixing_drupal_json_output.patch2.13 KB

Comments

#1

Status:active» needs review

...

#2

Hey, I am running a bigger update on heartbeat plugins currently. When reviewing the patch in #1345900: disabling i like flag -> fatal error , I realized there is something not ok in the process of loading/viewing attachments.
After that, all the rest of the patches will come (and hopefully some can be closed automatically due to the refactoring.

regards

#3

Status:needs review» fixed

Pushed to git.

#4

Status:fixed» needs work

Sorry didn't test it well enough. The ajax call is working but i don't get proper results...

#5

What do you mean with proper results?
- Wrong stream is loaded in ajax?
- Messages are too young or too old?
- some other problem?

I seems it works fine here on the public stream.

#6

Status:needs work» closed (fixed)

This is fixed in another issue. Please create a new issue if another problem rises.

nobody click here