Me again.... Ajax comments are broken due to depreciated function drupal_json in D7. See the patch!

CommentFileSizeAuthor
fixing_drupal_json_output.patch2.13 KBmuschpusch

Comments

muschpusch’s picture

muschpusch commented
Status: Active » Needs review

...

Stalski’s picture

Stalski commented

Hey, I am running a bigger update on heartbeat plugins currently. When reviewing the patch in #1345900: disabling i like flag -> fatal error , I realized there is something not ok in the process of loading/viewing attachments.
After that, all the rest of the patches will come (and hopefully some can be closed automatically due to the refactoring.

regards

Stalski’s picture

Stalski commented
Status: Needs review » Fixed

Pushed to git.

muschpusch’s picture

muschpusch commented
Status: Fixed » Needs work

Sorry didn't test it well enough. The ajax call is working but i don't get proper results...

Stalski’s picture

Stalski commented

What do you mean with proper results?
- Wrong stream is loaded in ajax?
- Messages are too young or too old?
- some other problem?

I seems it works fine here on the public stream.

Stalski’s picture

Stalski commented
Status: Needs work » Closed (fixed)

This is fixed in another issue. Please create a new issue if another problem rises.