missing page-bottom

function system_system_info_alter(&$info, $file, $type) {
  // Remove page-top from the blocks UI since it is reserved for modules to
  // populate from outside the blocks system.
  if ($type == 'theme') {
    $info['regions_hidden'][] = 'page_top';
    $info['regions_hidden'][] = 'page_bottom';
  }
}
CommentFileSizeAuthor
#5 comment_about_page_bottom-1360416-5480974.patch770 bytesLSU_JBob
#1 doc.patch767 bytesdroplet
doc.patch672 bytesdroplet

Comments

droplet’s picture

droplet commented
StatusFileSize
new doc.patch767 bytes
tregeagle’s picture

tregeagle commented
Issue tags: +DDU2012

Simple comment change, patch applies cleanly

tregeagle’s picture

tregeagle commented
Status: Needs review » Reviewed & tested by the community
xjm’s picture

xjm
she/her
Primary language English
commented
Status: Reviewed & tested by the community » Needs work

Thanks for the patch. I noticed one grammatical error:

+++ b/core/modules/system/system.moduleundefined
@@ -2722,8 +2722,8 @@ function system_region_list($theme_key, $show = REGIONS_ALL) {
+  // Remove page-top and page-bottom from the blocks UI since it is reserved for
+  // modules to populate from outside the blocks system.

I think we need to say "they are" now that we are referring to two regions?

LSU_JBob’s picture

LSU_JBob commented
Status: Needs work » Needs review
StatusFileSize
new comment_about_page_bottom-1360416-5480974.patch770 bytes

changed to "they are"... picked up from novice queue

xjm’s picture

xjm
she/her
Primary language English
commented
Status: Needs review » Reviewed & tested by the community

Thanks, looks great.

xjm’s picture

xjm
she/her
Primary language English
commented
Title: comment about page_bottom hided from blocks UI » Document that the page_bottom region is hidden from the blocks UI
droplet’s picture

droplet commented

Thanks.

also share your thought to a following up/relative issue: #1360428: remove page_top & page_bottom from theme info

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Component: system.module » documentation
Status: Reviewed & tested by the community » Fixed

Committed and pushed to 8.x and 7.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.