Usability: Password+confirmation cannot be marked required

Except that these are not required in user/X/edit. Confirm password is only required if you put something in the first password box. I think...

mkalkbrenner is correct that the password file is required in certain cases, such as admin/user/user/create, but the current code does not properly allow this to be displayed. I noticed this tonight on the admin user page and came up with the exact same patch, which properly transfers the required property of the password form (whether it is set to TRUE or FALSE).

"password file" -> "password field"

As long as I'm updating I'll also note that this is a simple port to d6 as well.

Here's the direct d6 patch.

Oops. I took a quick look at the patch and somehow thought it was doing a blanket set of #required => TRUE instead of passing the required value along in theme_password. You're right.

Bump - this is still RTBC unless someone has issues with it.

This patch looks OK to me, although it would be comforting to get chx's or Eaton's "+1". :)

+1 works as advertised, all the patch changes is making it obvious that required fields are required.

A similar fix for this issue was posted back in March, btw: http://drupal.org/node/126549

Patch no longer applies against CVS HEAD. I'll go ahead and commit it, as soon it's re-rolled.

I thought about it some more and came up with a slightly more abstract patch. It combines the #size and #required pass-throughts into a more general foreach loop.

I also realized that a simple array_merge on pass1 and pass2 would allow forms to individually customize the form attributes for those elements. So with this patch you could specify a description or other custom attributes just for pass1 (or just for pass2), which wasn't possible previously.

Buuump.

Chris, I liked the first patch better -- more transparent and easier to follow. I've re-rolled that patch and committed it to CVS HEAD. Thanks.

Fair enough - it should be fixed in D5 too though.

The committed patch, http://cvs.drupal.org/viewcvs/drupal/drupal/includes/form.inc?r1=1.200&r..., does not apply to Drupal 5 CVS. It will need a reroll.

You can use the patch in the original issue post - it's against D5 and is equivalent to what was committed.

Committed to 5.