Hi,
I am testing this module, and thank god, I made a database backup.
I have a regional vocabulary with nodes attached of self made nodetypes.

I didn't change anything on the standard settings and tried the module.
All terms where deleted, not the terms with no nodes attached.

What are the right settings to only delete the orphan nodes?

Thanks a lot in advance for your reply.
Greetings, Martijn

Comments

matt v.’s picture

matt v. commented
Status: Active » Postponed (maintainer needs more info)

The default settings should only delete just the orphaned terms. They do, in my testing. Can you try the new beta 1 release? If the problem persists, can you try to describe a scenario to recreate the problem you're seeing?

Thanks!

summit’s picture

summit commented

Hi,
The terms are placed because of term-field references in my nodes. Could may be that be the problem?
greetings, Martijn

acidpotato’s picture

acidpotato commented
Version: 7.x-2.x-dev » 7.x-2.0-beta1

With default settings this module deleted terms for content type which had taxnomy terms as term reference field. In theory should not happen as per the module description. Pruning threshold = 0, so that's not the reason. This is a dangerous module if left on auto. +1 for the safety checks tho.

matt v.’s picture

matt v. commented
Assigned: Unassigned » matt v.
Category: support » bug
Status: Postponed (maintainer needs more info) » Needs work

I've tracked down what probably explains why some users are seeing this kind of issue. The module uses taxonomy_term_delete and in a hierarchical vocabularies when taxonomy_term_delete deletes parent terms it also deletes all child terms (regardless of whether they are orphaned or not).

In the short term, I've added some warning text to the module, while I try to figure out a more optimal solution.

matt v.’s picture

matt v. commented
Status: Needs work » Fixed

This should now be fixed by commit 9081ae4.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

MGParisi’s picture

MGParisi commented
Status: Closed (fixed) » Needs work

Beta 1 still deletes ALL TERMS in my database. Tried it twice!

matt v.’s picture

matt v. commented
Status: Needs work » Postponed (maintainer needs more info)

@MGParisi Can you provide some more details about your site's terms? For instance, are all your terms in a single vocabulary? Are the terms arranged hierarchically?

Also, can you detail specific steps you used to recreate the issue?

MGParisi’s picture

MGParisi commented

I don't use a hierarchical taxonomy, and I basically installed it and pushed the delete button. It runs for a few then it lists all of my terms deleted.

matt v.’s picture

matt v. commented
Status: Postponed (maintainer needs more info) » Fixed

@MGParisi,

I just realized that you specified in Comment #7 that you were running Beta1. The Beta1 release is over 2 years old. Please update to the 7.x-2.0-beta2 release, which was released over a year ago now. There are lots of bug fixes in the 7.x-2.0-beta2 release, including the fix for this issue mentioned in Comment #5 above.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

smitty’s picture

smitty commented
Issue summary: View changes
Status: Closed (fixed) » Needs work

This issue is definitly not solved. Neither on beta-2 nor on dev as of 30.09.2013.

tecto’s picture

tecto commented

Patch from https://www.drupal.org/node/1819344 solves this issue.