After enabling the latest -dev version of Autosave, I was getting the following error:

"Call-time pass-by-reference has been deprecated in drupal_load()" (line 935 of includes/bootstrap.inc)

I traced this back, and to solve the problem you just need to change "autosave.module" on line 171 from

$form = drupal_build_form($form_id, &$form_state);

to

$form = drupal_build_form($form_id, $form_state);
CommentFileSizeAuthor
#3 autosave-1361446-3.patch667 byteslee20

Comments

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Needs review » Reviewed & tested by the community

Confirmed, the above change fixes the error. This appears in PHP 5.3+ only, PHP 5.2 is not affected.

Crell’s picture

Crell commented
Status: Reviewed & tested by the community » Needs work

There is no patch here, so it cannot be RTBC. Please provide a patch.

lee20’s picture

lee20 commented
Status: Needs work » Needs review
StatusFileSize
new autosave-1361446-3.patch667 bytes

Attached is a patch.

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Needs review » Reviewed & tested by the community
Crell’s picture

Crell commented
Status: Reviewed & tested by the community » Fixed

The patch in #3 wasn't rolled from the module root but site root. Please do not submit patches rolled from site root as those will not apply cleanly.

I was able to correct the patch and apply it. It's now been committed. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.