This is a tracking issue for Coder Advisory Review issues in all projects. Coder advisory reviews on qa.drupal.org use both Coder Review and coder tough love.
False positives
- #822260: Coder does not recognize class or method names in @see blocks.
- #1361528: Remove "@param and @return syntax does not indicate the data type" rule
- #699196: False positive on "Administrative menu items should have a description"?
- #1390040: several datatypes are not matched in API docs, triggering '@param and @return descriptions begin indented on the next line'
- #898200: D7 false detection: HTML is allowed in translatable strings
- #1390592: D7: statements should probably be wrapped in db_rewrite_sql()
- #337394: False positive: format_date
- #1539698: False positive for @see
- #1547082: Don't throw error for =&
- #1805602: Fix false-positives on * Implementation of hook_foo(). in Drupal 7.
- #1805606: Critical warning when !placeholder used in t() functions - should be simple notice
- #1805608: Don't warn for use of substr()
Missing coverage
See also: #1299710: [meta] Automate the coding-standards part of patch review
Comments
Comment #0.0
xjmUpdated issue summary.
Comment #0.1
xjmUpdated issue summary.
Comment #0.2
xjmAdding issues.
Comment #1
NROTC_Webmaster commentedIssues #898200: D7 false detection: HTML is allowed in translatable strings and #1390592: D7: statements should probably be wrapped in db_rewrite_sql() are both Coder Tough Love issues and if CTL is being removed then I don't see that either of them should be blocking this.
Comment #2
filijonka commentedI would guess this is also interesting? can create false positives #1522086: incorrect structure of docblock not found
Comment #2.0
filijonka commented.
Comment #2.1
NROTC_Webmaster commentedUpdated issue summary.
Comment #2.2
sphism commentedUpdated issue summary.
Comment #3
geerlingguy commentedI just added #1805588-1: Make honeypot pass coder review to the list; it's fine to add notices here and there, but there are a few things coder review is marking as critical or normal errors that, according to API documentation, are perfectly acceptable and normal (and sometimes recommended) ways of writing Drupal code.
Comment #3.0
geerlingguy commentedAdded another list of false-positives.
Comment #3.1
geerlingguy commentedBroke out honeypot issues individually.