I ran it through the new automated coder review: http://qa.drupal.org/pifr/test/199653

Half of these are false positives, see #822260: Coder does not recognize class or method names in @see blocks. and #737372: Overly aggressive matching on "date" pattern.

CommentFileSizeAuthor
#4 fullcalendar-1361540-4.patch9.96 KBtim.plunkett
#1 fullcalendar-1361540-1.patch11.66 KBtim.plunkett

Comments

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
Status: Active » Needs review
StatusFileSize
new fullcalendar-1361540-1.patch11.66 KB

Here's a start. Unfortunately, d.o also uses Coder Tough Love, and that's 6.x only, so I don't know how to run it locally.

It complains about "FullCalendar Colors" being title case, but I think I'll just ignore it because "FullCalender options" is too confusing compared to "FullCalendar Options".

aspilicious’s picture

aspilicious commented

Looks good

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
Assigned: Unassigned » tim.plunkett
Status: Needs review » Postponed

Made one commit: http://drupalcode.org/project/fullcalendar.git/commit/f8f5d18
Postponing until the testbot false positives are cleared up, and then I'll retest.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
Assigned: tim.plunkett » Unassigned
Status: Postponed » Needs review
StatusFileSize
new fullcalendar-1361540-4.patch9.96 KB

I ran it through jslint, here's some cleanup.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
Status: Needs review » Postponed

Commited http://drupalcode.org/project/fullcalendar.git/commit/b0bf1d0 and http://drupalcode.org/project/fullcalendar.git/commit/8e2a263, moving back to postponed until the testbots are updated.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
Status: Postponed » Fixed

Closing this. I'm never using a <br /> no matter what.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.