uc_cmpay

Link to project page is missing: http://drupal.org/sandbox/spiritfelix/1361654
git clone http://git.drupal.org/sandbox/spiritfelix/1361654.git uc_cmpay

Automated review: http://ventral.org/pareview/httpgitdrupalorgsandboxspiritfelix1361654git

Your still working in the master branch, please have a look at the instructions here:
http://ventral.org/pareview/httpgitdrupalorgsandboxspiritfelix1361654git

Try to fix all the stuff the automated review throws and retry reviewing it your self here: http://ventral.org/pareview

If you think something in the automated review is wrong or you have problems to understand some points, just ask!

Switched back to needs review, so in-depth reviews won't be blocked by coding standart issues.

coding standards

It appears you are working in the "master" branch in git. You should really be working in a version specific branch. The most direct documentation on this is Moving from a master branch to a version branch. For additional resources please see the documentation about release naming conventions and creating a branch in git.
Review of the master branch:

• ./uc_cmpay.inc: all functions should be prefixed with your module/theme name to avoid name clashes. See http://drupal.org/node/318#naming
  

  function gb2utf8($gb) {
  function gb2unicode($gb) {
  

• Run coder to check your style, some issues were found (please check the Drupal coding standards). See attachment.
• Drupal Code Sniffer has found some code style issues (please check the Drupal coding standards). See attachment.

This automated report was generated with PAReview.sh, your friendly project application review script. You can also use the online version to check your project. Go and review some other project applications, so we can get back to yours sooner.

manual review:

• wrong git branch name, "6.x-1.0" should be "6.x-1.x".
• "Implements of hook_uninstall()." should be "Implements hook_uninstall().", also on the other hook implementations.
• uc_cmpay_uninstall(): you do not define a schema, so you do not need to uninstall one.
• uc_cmpay_payment_method_cmpay(): all text for transalation in t() should be in English.
• Same for comments.

Moving from a master to a major version branch (6.x-1.0).

the date showed on a pareview report on ventral.org only shows who did the first submit.
So you got the most recent result, just ignore the shown date (I'll turn of this off in future).

Please do not assign your own applications, only the current reviewer should do this

Hi,

Manual Review :

1. Please use l() to create image and link markup in uc_cmpay.module line45 .
2. Use English words instead 个别浏览器暂时无法使用 ,enclosed with t() and also in other places throughout the file.
3. use drupal builtin function ip_address in function uc_cmpay_getclientip() in file uc_cmpay.inc.
4. Please use t() for all titles . ex : 'title' => 'cmpay payment return' should be 'title' => t('cmpay payment return')
5. Also modify markup coding in uc_cmpay.module line 206 .
6. Use drupal_urlencode instead of normal encode in uc_cmpay.inc.
7.It seems there is a problem in validating your code in PAREVIEW . Please check and clear it.

Thanks,

Closing due to lack of activity. Feel free to reopen if you are still working on this application.

branch to 6.x-1.x