I believe both of these come from hard-coded places, so if they are xss then the exploit vector includes the ability to write plugin code which means...you are already in trouble

That said, there's no reason I could find to simply include plugin titles without some form of filtering just in case. These should be plain text rendered to a browser as plain text.

CommentFileSizeAuthor
#1 1361936_some_filtering.patch1.16 KBgreggles

Comments

greggles’s picture

Status: Active » Needs review
StatusFileSize
new1.16 KB
e2thex’s picture

Status: Needs review » Fixed

Applied here
http://drupalcode.org/project/boxes.git/commit/aaec34a

d7 version
http://drupalcode.org/project/boxes.git/commit/c25b38e

Thanks for the catch.

There are modules (like entity_boxes), that programaticly define box types, so this could be an issue.

greggles’s picture

Good to know - luckily the lack of a release on http://drupal.org/project/entity_boxes means it doesn't need an SA.

Thanks, e2thex!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.