Simplify blocking IP address range

Doh! I swapped the original and modified versions in my diff/patch. Here is the right one.

Regards
FrankZabbath (http://bembelbee.wordpress.com/)

I've rewritten to allow for setting an IP block as _either_ a whitelist or a blacklist.

Basically I just took the code already used to create whitelist IP blocks and generalized it to be used
for either white or blacklists.

See attached patch.

Automatically closed -- issue fixed for 2 weeks with no activity.

@deekayen & all: Could you confirm if the below steps are correct? If yes I'll add a new section to Troll INSTALL.txt file.
--------------------------------------------------------------------------------
Steps to block an IP address range.

1. Navigate to admin/user/troll/ip_blacklist/import
2. Into the field 'List:' type in all the IP address you want to block.
   One IP per line.
   The IP's format must be *.*.*.*/32
   Replace * by a number. You must add /32 at the end of each IP. Do not change this number.
   For example if I want to block all IP range from 204.11.52.0 to 204.11.52.255 then the list would be 256 lines long.
   204.11.52.0/32
   204.11.52.1/32
   204.11.52.2/32
   204.11.52.3/32
   [and so on until the below last line]
   204.11.52.255/32
   
3. To view the full list of blacklisted IPs navigate to admin/user/troll/ip_blacklist/search

--------------------------------------------------------------------------------

Is there an easier way than type in 255 lines of IPs? Like Token support? Anything else?

Not that I know of. It's currently possible but you have to manually type in all lines. For example type in all 255 lines of IPs you want to block.

Changing to category to feature request. As this would be a new feature. Or simplification of an already existing feature. Any volunteer for a patch? I would be happy to contribute testing.

That looks like it would be easier...

Quick question.. what is the difference between ip ban ad blacklist? Sounds like they are both the same function.. How do you know which one to use? Sorry if this sounds dumb, just woke up and haven't had my 2nd cup of coffee yet.

deekayen is correct. They both have the same end result but they go there using different ways. They both have their use though. In my case I use blacklisting to automatically blacklist IPs listed in trusted blacklist servers. Then on top of that I use IP ban to manually block users with bad behaviours.

okay that makes more sense.. thanks for the feedback on this.. So basically, just install the blacklists, then add suspicious or problem children in the ip ban section.. got it. Now to figure out how to solve the 404 error im getting when using 404 for all pages, even when using customerror module..get lots of php error log notices when trying to use this option.. so went and using the redirect to commonerror/403 instead.

Thanks for sharing #17 greywolfsspirit :)

greywolfsspirit could you confirm if the below 3 steps are correct? If yes I'll add a new section to Troll INSTALL.txt file.
--------------------------------------------------------------------------------
Steps to block an IP address range.

1. Navigate to admin/user/troll/ip_blacklist/import
2. Into the field 'List:' type in the start of IP range to block.
   For example if you want to block 172.16.254.0 through 172.16.254.255 then type in 172.16.254.0/24
   Notes:
   -The IP format must be *.*.*.*/24
   -Replace * by numbers. You must add /24 at the end. /24 is a CIDR notation. Read more at http://en.wikipedia.org/wiki/IPv4_subnetting_reference
3. To view the full list of blacklisted IPs navigate to admin/user/troll/ip_blacklist/search

--------------------------------------------------------------------------------

Thanks greywolfsspirit :) I'll update the INSTALL.txt file or README.txt file something like that.

I'm leaving this issue active because solution in comment #11 is for advanced admins. This feature request is for a simplify way for blocking IP address range. That beginner admins could use. See comment #11 to clarify.

I would like the block ip modification set up like the whitelist/black list abilties though.. where we can enter a range of ip's to block.. I mean, yeah, I can always go under users/access rules and block them there.. just would have been nice to have all the routines working in the same module.

With user/access rules, we can actually enter a % key for the ip address settings.. ie: 66.249.%.% to block 66.249.0.0 - 66.249.255.255

having issues with users accessing my files section anonymously, without logging in, even though the file system is set to private, and access to the file browser is not given to anonymous users.. in the access log, I see their activity getting an http code 302 or 304.. instead of 403 or 404s.. so.. just trying to batten down the hatches a bit more.