Failed to upload the picture image (Mass error for so many people)

Maybe a more specific title will get some attention!

Well, this is the validation part which results in the second error message:

if ($file = file_save_upload('picture_upload', variable_get('user_picture_path', 'pictures') .'/picture-'. $user->uid .'.'. $info['extension'], 1)) {
      $form_values['picture'] = $file->filepath;
    }
    else {
      form_set_error('picture_upload', t("Failed to upload the picture image; the %directory directory doesn't exist.", array('%directory' => variable_get('user_picture_path', 'pictures'))));
    }

The error message is misleading here (a Drupal bugfix is probably in order :), the directory could very well exist, but the file cannot be moved for some reason (as the first error message shows). It could happen that file or directory permissions are the reasons here (in the pictures directory).

I also comitted a wording fix to the error message to indicate that it might be because of permission problems.

cvs diff: Diffing .
Index: user.module
===================================================================
RCS file: /cvs/drupal/drupal/modules/user/user.module,v
retrieving revision 1.771
diff -u -p -r1.771 user.module
--- user.module 13 Apr 2007 08:56:59 -0000      1.771
+++ user.module 21 Apr 2007 20:44:42 -0000
@@ -331,7 +331,7 @@ function user_validate_picture($file, &$
       $form_values['picture'] = $file->filepath;
     }
     else {
-      form_set_error('picture_upload', t("Failed to upload the picture image; the %directory directory doesn't exist.", array('%directory' => variable_get('user_picture_path', 'pictures'))));
+      form_set_error('picture_upload', t("Failed to upload the picture image; the %directory directory doesn't exist or is not writable.", array('%directory' => variable_get('user_picture_path', 'pictures'))));
     }
   }
 }