Closed (duplicate)
Project:
Drupal.org security advisory coverage applications
Component:
module
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
6 Dec 2011 at 23:02 UTC
Updated:
31 Aug 2018 at 17:55 UTC
Jump to comment: Most recent
Comments
Comment #0.0
misc commentedBetter explained...
Comment #1
patrickd commentedYou got a few formatting errors: http://ventral.org/pareview/httpgitdrupalorgsandboxmikkex1363048git
It seems that you already tested it your self, do you have any questions on that?
Comment #2
misc commentedThanks. Yeah I tested it, the errors that are still left I do not understand how to fix.
Comment #3
patrickd commented27 | ERROR | Missing parameter type at position 1->
33 | ERROR | Data type of return value is missing->
46 | ERROR | Parameter comment must be on the next line at position 1->
89 | ERROR | String concat is not required here; use a single string instead4 | ERROR | The second line in the file doc comment must be " * @file"Put a @file comment block at the beginning of twingly_pane.module and describe the function of the file just like in twingly_pane_pane.inc
Hope this clarifies some issues!
Comment #4
misc commentedThanks for the explanation!
Have now updated the code and it seems there are no more formatting errors.
Comment #5
misc commentedJust a friendly reminder if somebody would like to test this module, if you have ctools installed it is really easy to test.
Comment #6
patrickd commentedSorry it seems like you got two application issues opened (http://drupal.org/node/1336946)
Unfortunatelly you can only hold one of these open, please close one of them!
(I'd suggest you to close the more recent one)
Comment #7
misc commentedClosed because of having two applications in the cue.
Comment #7.0
misc commentedspelling
Comment #8
avpaderno