Hi,

After installing this module I get these errors:

•Notice: Use of undefined constant GEOCODER_AUTOCOMPLETE_URL - assumed 'GEOCODER_AUTOCOMPLETE_URL' in include_once() (line 11 of /usr/home/deb16445/domains/mikesportel.nl/public_html/sis/sites/all/modules/geocoder_autocomplete/geocoder_autocomplete.module).
•Notice: Use of undefined constant GEOCODER_AUTOCOMPLETE_FORMAT - assumed 'GEOCODER_AUTOCOMPLETE_FORMAT' in include_once() (line 12 of /usr/home/deb16445/domains/mikesportel.nl/public_html/sis/sites/all/modules/geocoder_autocomplete/geocoder_autocomplete.module).
•Notice: Use of undefined constant GEOCODER_AUTOCOMPLETE_URL - assumed 'GEOCODER_AUTOCOMPLETE_URL' in include_once() (line 11 of /usr/home/deb16445/domains/mikesportel.nl/public_html/sis/sites/all/modules/geocoder_autocomplete/geocoder_autocomplete.module).
•Notice: Use of undefined constant GEOCODER_AUTOCOMPLETE_FORMAT - assumed 'GEOCODER_AUTOCOMPLETE_FORMAT' in include_once() (line 12 of /usr/home/deb16445/domains/mikesportel.nl/public_html/sis/sites/all/modules/geocoder_autocomplete/geocoder_autocomplete.module).
•Notice: Undefined index: size in geocoder_autocomplete_field_widget_form() (regel 52 van /usr/home/deb16445/domains/mikesportel.nl/public_html/sis/sites/all/modules/geocoder_autocomplete/geocoder_autocomplete.module).

The module seems to work however.

Hope this helps you in perfecting this module.

CommentFileSizeAuthor
#4 1363676-4-geocoder_autocomplete-notices.patch1.47 KBpfrenssen
#1 geocoder_autocomplete-undefined_constants-1363676-1.patch535 bytescyborg_572

Comments

cyborg_572’s picture

cyborg_572 commented
Status: Active » Needs review
StatusFileSize
new geocoder_autocomplete-undefined_constants-1363676-1.patch535 bytes

The first 4 notices are because the constant definitions are missing quotes, and I've attached a patch to fix them. That last notice seems unrelated, and I'm not getting it with the setup on the site I'm working on. If it does pop up I'll have a look into then.

jordi_bcktt’s picture

jordi_bcktt commented

Thank you, is working now.

bjalford’s picture

bjalford commented
Status: Needs review » Reviewed & tested by the community

Works fine

pfrenssen’s picture

pfrenssen
Location Sofia
commented
Status: Reviewed & tested by the community » Needs review
StatusFileSize
new 1363676-4-geocoder_autocomplete-notices.patch1.47 KB

Updated patch with a fix to the other reported notice.

gagarine’s picture

gagarine commented
Status: Needs review » Reviewed & tested by the community

#4 work for me thanks

gvanto’s picture

gvanto commented

moved to diff forum ...

gvanto’s picture

gvanto commented

when I try and apply the patch, I get errors (says target file not found):

[root@host:/home/zingleco/public_html/dev2/sites/all/modules/geocoder_autocomplete]# patch -p0 --dry-run < 1363676-4-geocoder_autocomplete-notices.patch
can't find file to patch at input line 14
Perhaps you used the wrong -p or --strip option?
The text leading up to this was:
--------------------------
|From 28f7f706b690786e5f2b1333f7173b7605b1de4d Mon Sep 17 00:00:00 2001
|From: Pieter Frenssen
|Date: Wed, 14 Mar 2012 01:30:30 +0100o
|Subject: [PATCH] Issue #1363676 by cyborg_572, pfrenssen: Fix notices.
|
|---
| geocoder_autocomplete.module | 6 +++---
| 1 file changed, 3 insertions(+), 3 deletions(-)
|
|diff --git a/geocoder_autocomplete.module b/geocoder_autocomplete.module
|index 26a95e4..79a4f88 100644
|--- a/geocoder_autocomplete.module
|+++ b/geocoder_autocomplete.module
--------------------------
File to patch:

[Here I hit ctrl-C as I didn't expect this?]

PS, files are all there:
[16:13:23][root@host:/home/zingleco/public_html/dev2/sites/all/modules/geocoder_autocomplete]# ls
./ 1363676-4-geocoder_autocomplete-notices.patch geocoder_autocomplete.module LICENSE.txt
../ geocoder_autocomplete.info geocoder_autocomplete.pages.inc .svn/

pfrenssen’s picture

pfrenssen
Location Sofia
commented

@gvanto Use patch -p1. Check the man page for patch for more info.

mxt’s picture

mxt
Primary language Italian
Location Milan
commented

Patch provided in #4 resolve the issue and works very well for me.

Can this be committed please?

Thank you very much

twistor’s picture

twistor commented

Patch works for me as well.

kbasarab’s picture

kbasarab commented

Patch in #4 works for me as well.

Taxoman’s picture

Taxoman commented

Time to commit to -dev?

sanduhrs’s picture

sanduhrs
he/him
Primary language German
Location 🇪🇺 Heidelberg, Germany, Europe
commented
Status: Reviewed & tested by the community » Fixed

Commited to dev.
Thanks.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.