My website runs ubercart-6.x-2.7 with uc_checkoutfi-6.x-1.1.
When paying an order, 2 identical confirmation emails are sent to the user and 2 to the administrator.
This looks like the same problem as #1332130: Duplicate emails when using 2Checkout.
I tested a fix similar to the patch written for this issue: if I move "uc_order_save($order)" before the call to "uc_payment_enter([...])" in function uc_checkoutfi_complete(), then the correct number of emails get sent. However I'm not familiar enough with the code to tell whether it's a correct fix.
| Comment | File | Size | Author |
|---|---|---|---|
| #2 | uc_checkoutfi-fixed_duplicate_order_confirmation_emails-1364114-1.patch | 1.08 KB | operinko |
Comments
Comment #1
Neo Mithrandil commentedThis bug could really use some attention.
I'm also seeing race conditions when users click several times on "Return to seller's service" in the netbank, causing some orders to be left "in checkout" even though payment was received. The frequency of these failures goes down more than ten-fold if I remove the "uc_order_save($order)" call as described above.
Comment #2
operinko commentedTested the fix, seems to work as intended.
From what I could gather, the uc_order_comment_save manages to trigger the "New order" email.
Comment #3
demoshane commentedCan confirm this, clients get double emails after completing order.
Comment #4
operinko commentedShould be fixed in commit 547b51b on 6.x-1.x.
Comment #5
demoshane commentedProblem arises in D7 version aswell.
Comment #6
operinko commentedFixed for 7.x-1.x in commit 69c48f2.
Comment #7
operinko commentedComment #8
Neo Mithrandil commentedThanks for the fix!
As mentioned in comment #1 some race conditions in payments may still exist after this, but I'll file a new bug if I can collect enough data about them.
Comment #9
Neo Mithrandil commentedClosing this bug.