Frontpage Viral Campaign Website

You got some coding style errors, please try fixing them using http://ventral.org/pareview.
If you got any questions on this, please ask!

The problem is that you editor seems to have auto-indenting turned on. so you got many lines like (# is a whitespace):

function lp_email_block_info() {
  $blocks['subscribe'] = array(
    'info' => t('Subscription Form'),
  );
##
  return $blocks;
}

Please stop pushing to the master branch and see the instructions on top of the review results.

I checked lp_referral.js and it does not have a single new line at the fileend, maybe you'r using windows encoding?

That's strange, but now I also got the new line in my editor.
But this is not a big problem, if you get this solved later it's okay.

sorry but, please don't review your drupal distribution by ventral.org, this will currently break the server :/

Review of the LaunchPlug 7.x-1.x branch:

• Drupal Code Sniffer has found some code style issues (please check the Drupal coding standards). See attachment.

This automated report was generated with PAReview.sh, your friendly project application review script. You can also use the online version to check your project. Go and review some other project applications, so we can get back to yours sooner.

manual review:
lp_report_top_referrals(): make sure to run all user facing text through t() for translation.

Review of the LaunchSkin 7.x-1.x branch:

• README.txt is missing, see the guidelines for in-project documentation.
• Bad line endings were found, always use unix style terminators. See http://drupal.org/coding-standards#indenting
  

  ./css/style.css:                            ASCII C program text, with CRLF line terminators
  ./launchskin.info:                          ASCII text, with CRLF line terminators
  css/style.css
  js/script.js
  launchskin.info
  theme-settings.php
  

manual review:
base.css: Please format it according to the CSS coding standards http://drupal.org/node/302199

LaunchBuzz: do not copy Drupal to your drupal.org installation profile repository. You should only have your installation profile there and optionally a drush make file.

Sorry for the long delay! I had a raw look on it:

LaunchBuzz installation profile

1. Please add a @file documentation block to all php-code containing files
2. use base_path() instead of globals (it's kind of the same..)
3. don't push foreign modules (follow module) into your repo, please read the documentation about that. there were some changes about this on drupal.org recently
4. don't concatenate strings within t()/st() use @/%/! placeholders instead
5. prefix used variables with the full installation profile name
6. many parts of the .install process came from standarts profile, as it enables a lots of stuff per default, it's better to use the minimal profile as basis. maybe you can still remove some stuff here to make it more lightweight, or is it all needed?
7. Make a README.txt that follows the guidelines for in-project documentation.
8. The theme launchskin is not contained here, but it's expected to be there in your .install file. remove the empty themes directory and add a dependency to it
9. where is this "launchplug" module you've directory for?
10. There's some stuff (even there are some false positive's so read with care) found by automated review: http://ventral.org/pareview/httpgitdrupalorgsandboxjonloh1360618git

LaunchPlug module(s)

1. lp_email module is the dependency of the other two modules, instead of making "a set of modules" you should rather make a lp_email module with the other as submodules (would make more sense for me).. I'm also not sure if it's really necessary to split them up, but that's your choise
2. Please make your README.txt follow the guidelines for in-project documentation.
3. All used variable names have to be prefixed with the full module name
4. Used variables have to be deleted by variable_del() at hook_uninstall() in the .install file
5. All human readable strings must be encapsuled with t(). also default values for variables (but not strings in hook_menu)

6. if (module_exists('lp_referral')) {
           $form['referral_fieldset'] = array(

   If the referral module needs alterations in the settings form, these alterations should be done by the referral module itself (hook_form_form_id_alter())

7. I think most of the work your doing in the submit handler can also be done by system_settings_form_submit()
8. $delta should be prefixed with the full module name
9. // Avoid query duplication.have you tested this? is this really an issue, I mean is this possible? I got no idea..
10. 'restrict access' => TRUE,this hook menu option is only for really critical permissions that make the user able to kind of take down the whole site or other security issues. I don't think that's the case here

regards

Closing due to lack of activity. Feel free to reopen if you are still working on this application.

Added --branch 7.x-1.x command for Git.