The built in support of Superfish is a nice easter egg. Thx!

However while the Superfish menu module is unobtrusive itself, it does not work in Corolla if I disable JS in my browser.

Comments

Jeff Burnz’s picture

Jeff Burnz commented

Why is this posted against this theme? Aren't you talking about the module?

thamas’s picture

thamas
Primary language Hungarian
Location Hungary
commented

Well, 'cause the module works on its demo page (http://mehrpadin.net/demo/superfish) with disabled JS. The module also works with the default Bartik theme with disabled JS.

That is why I thought that it is the issue of Corolla. I do not really know that the module should support themes or themes should support the module (however you wrote in the ReadMe.txt of Corolla that "corolla supports the Superfish module").

Thanks for your work with your cool themes. If I was wrong, please set this issue against Superfish.

thamas’s picture

thamas
Primary language Hungarian
Location Hungary
commented
Title: Superfish doesn't work with disabled JS » Superfish doesn't work with disabled JS in Corolla
Jeff Burnz’s picture

Jeff Burnz commented
Category: bug » feature
Status: Active » Closed (won't fix)

Edge case, sorry but I really don't have time to work on extreme edge cases such as this, I can only focus on the really big issues that might affect most users.

If you can pinpoint the problem and provide a fix I will commit it, otherwise its a won't fix.

thamas’s picture

thamas
Primary language Hungarian
Location Hungary
commented
Assigned: Unassigned » thamas
Category: feature » bug
Status: Closed (won't fix) » Needs review

OK. Let me see… :o)

It is defined in the 66. line of navigation.css

ul.sf-menu li ul {
  display: none; /* Prevent sub menus from momentarily displaying */
}

This is what prevents displaying submenu items when JS disabled. However this is not needed, 'cause "display: none;" is defined dynamically (when JS enabled) as an inline style for "ul.sf-menu li ul" by the SF module. (And when JS disabled, we don't want this setting.)

Jeff Burnz’s picture

Jeff Burnz commented
Title: Superfish doesn't work with disabled JS in Corolla » Superfish dropdowns don't show with JavaScript disabled in Corolla
Assigned: thamas » Unassigned
Category: bug » feature

I am really cagey about removing that - what happens is that you can get flashes of the entire menu if JS is slow to load, so having this in the CSS completely negates the possibility of that happening. I've noticed this happens especially if the theme styles are heavy, meaning a lot of CSS and images to load, and Corolla is not a light theme by any means - its has a lot of CSS.

A lot of people have complained over the years about that issue (all menus showing momentarily until the dynamic class is added), so personally I am against removing it by default.

That's probably not the enthusiastic answer you were looking for but I have to go with the "most expected behavior", which in my experience is all menus hidden by default, rather than no JS working menus.

I'll leave this open and see if we can get some feedback over the next few weeks from users.

thamas’s picture

thamas
Primary language Hungarian
Location Hungary
commented
Issue summary: View changes

corrected a typo