Download & Extend
Bibliography Module » Issues

Common fields show up regardless of visibility, some labels missing

Posted by lpeabody on December 8, 2011 at 5:58pm
Project:Bibliography Module
Version:7.x-1.x-dev
Component:User interface
Category:bug report
Priority:normal
Assigned:Unassigned
Status:closed (fixed)

Issue Summary

It appears that fields that are set as Common show up regardless of visibility specification.

Also, for a few select biblio types, the labels defined under Common do not display above the field when filling out a form when having specified a particular publication type. For example, when I select a Journal Article, all fields marked as Common are missing their labels and hints.

Login or register to post comments

Comments

#1

Posted by lpeabody on December 8, 2011 at 6:34pm

My fix for this at the moment is trolling through the database looking up the specific entries in biblio_field_type_data and changing them to what I need.

#2

Posted by lpeabody on December 9, 2011 at 1:48am

removed

EDIT: Sorry Ron, I have too many issue pages open, I meant to put this in another thread!

#3

Posted by rjerome on December 9, 2011 at 12:46am

I'm not exactly sure what you are referring too, but if it's working, it's all good.

#4

Posted by lpeabody on December 9, 2011 at 1:49am

Nothing is actually fixed, I just posted in the wrong thread >_>

#5

Posted by rjerome on December 9, 2011 at 2:40am

Ahh that explains why I didn't understand what you were referring to :-)

I can't reproduce your original issue. Can you confirm that that there actually something set for the default title on the admin/config/content/biblio/fields page with the Publication type set to common.

As an example, the two attached image show the "common" and "journal article" specific entries for the biblio_secondary_title field. If you check the "common" check box the "common" title should be displayed on the field for all publication types, otherwise the "type specific" title is displayed for that field.

AttachmentSize
field_titles_common.png 21.37 KB
field_titles_journal.png 21.53 KB

#6

Posted by natuk on December 19, 2011 at 12:30pm

The common labels are missing for me as well. See attached screenshots.

AttachmentSize
common-labels-exist.png 50.08 KB
conf-pap-labels-missing.png 50.04 KB

#7

Posted by dpnewb on May 15, 2012 at 5:28pm

I am experiencing the same issue. It prevents users from adding new Journal Article content since they don't know what the field is supposed to be and it is configured as a required field. Notice that on the Add Content page for a Journal Article on the Publications tab the Year field is missing the label.

AttachmentSize
field_titles_common.png 10.58 KB
field_titles_journal_articl.png 12 KB
add_content_journal_article.png 12.22 KB

#8

Posted by johnsonj on July 10, 2012 at 8:14pm

Any word on this bug? I'm experiencing the same issue.

#9

Posted by teresas on August 17, 2012 at 4:24pm

Subscribe

#10

Posted by teresas on August 17, 2012 at 4:47pm

This is really silly, but I found a temporary fix(?). For some reason when I made sure that none of the fields were "required", all the labels displayed properly. Is there a status update on this issue?

#11

Posted by enochRoot on September 4, 2012 at 8:19am

I'm only missing the Label for the 'Year' field. [7.x-1.0-rc4]

#12

Posted by rjerome on September 6, 2012 at 2:00am

I think this is fixed in the -dev version (at least I can't reproduce it in the -dev version), so if someone would like to test that theory and report back that would be great. I am planning on issuing a new rc release within the next week so it would be good to know if this is still an issue prior to the next release.

#13

Posted by autopoietic on March 6, 2013 at 2:04pm

I found that resetting all types to default initially resolved the problem of labels not showing up.

Even when the labels are then customised again, they display correctly. This appears to work in both 7.x-1.0-rc4 and 7.x-1.0-rc5.

Unfortunately I do not believe this is a solution for us, because we have content in some custom publication types, and though the reset seems to leave these types available (we could then re-edit labels) the biblio settings page for the custom publication types give the following error:

Notice: Undefined variable: fields in biblio_admin_types_edit_form() (line 819 of <drupal root>modules/contrib/biblio/includes/biblio.admin.inc).
Warning: uasort() expects parameter 1 to be array, null given in biblio_admin_types_edit_form() (line 842 of <drupal root>modules/contrib/biblio/includes/biblio.admin.inc).
Warning: Invalid argument supplied for foreach() in biblio_admin_types_edit_form() (line 848 of <drupal root>modules/contrib/biblio/includes/biblio.admin.inc).
Notice: Undefined variable: tab_data in biblio_admin_types_edit_form() (line 922 of <drupal root>modules/contrib/biblio/includes/biblio.admin.inc).
Warning: Invalid argument supplied for foreach() in biblio_admin_types_edit_form() (line 922 of <drupal root>modules/contrib/biblio/includes/biblio.admin.inc).

#14

Posted by rjerome on March 11, 2013 at 12:09am
Status:active» fixed

I believe I found the issue causing labels to go missing and fixed it.

http://drupalcode.org/project/biblio.git/commit/2978e01

#15

Posted by System Message on March 25, 2013 at 12:10am
Status:fixed» closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.