'Create new table' multistep form needs updating for D7: error "Undefined index: storage"

Same problem for me on Drupal 7.9 and a bunch of other modules active.
MySQL: 5.1.56
PHP: 5.2.17
Apache

Same on 7.x-1.x-dev
PHP 5.2.6-1+lenny13
MySQL 5.0.51a
Apache2

$form['storage'] is not part of Drupal 7 anymore.

Check for example:
http://drupal.org/node/918948

API docs
http://api.drupal.org/api/drupal/includes--form.inc/group/form_api/7

Unfortunately my PHP skills are non-existent so I can only supply some info. :(

This is useful reading: http://randyfay.com/node/66

I'll try to get onto this but if anyone wants to beat me to a patch that would be great -- please assign the issue to yourself to let everyone know you're working on it.

i got the same problem

+1.

In lieu of a fix I managed to get around this by going the other way. I created the table directly in the database within phpmyadmin, you can then use the adopt tab to register it (orphaned table) within data module.

I don't care where I create the table, I just need to export the schema from data into php so for my use case works fine.

Rich

that works, but i got other problems, the edit item link doesn't work, and relationships in views, to display 2 tables in same view

Updating issue title.

+1

What started as some troubleshooting for the "data_ui_create_form" error ended up in a rewrite of the data_ui.admin.inc file.

After making the D7 changes for tracking the multistep form, I kept getting a "maximum nesting" level error.

Strangely changing the name of the form from data_ui_create_form <code/>to<code> data_ui_create_data_form fixed the issue.

I also added some labels to the form elements in _data_ui_field_form so that users could see what the different fields and checkboxes were for.

The new form is working locally but I'm unable to successfully test because of the call to db_escape_string in DataHandler.inc. See http://drupal.org/node/1419798

The patch updates data_ui.admin.inc as well as data_ui.module (because of the form name change).

> Strangely changing the name of the form from data_ui_create_form

to<code> data_ui_create_data_form fixed the issue. 

Weird! I wonder if there's an accidental hook clash there or something.

Patch looks good on an eyeball review, just a few things to tweak:

<code>
+++ b/data_ui/data_ui.admin.inc
@@ -291,12 +291,18 @@ function data_ui_adopt_form_submit($form, &$form_state) {
-/**
- * Form callback for create table form.
- */
-function data_ui_create_form($form, &$form_state) {

Can you either keep or rewrite the docblock? All functions need to have one.

+++ b/data_ui/data_ui.admin.inc
@@ -291,12 +291,18 @@ function data_ui_adopt_form_submit($form, &$form_state) {
+    // Display page 2 if $form_state['page_num'] == 2
...
+    // Otherwise we build page 1.
+    $form_state['page_num'] = 1;

Incorrect indentation (and more similar further on).

+++ b/data_ui/data_ui.admin.inc
@@ -316,35 +322,52 @@ function data_ui_create_form($form, &$form_state) {
+    // We won't bother validating the required 'color' field, since they

That comment looks like it's copied from Examples module! ;)

+++ b/data_ui/data_ui.module
@@ -92,11 +92,11 @@ function data_ui_menu() {
-  );
+  );  ¶

Watch out for whitespace changes.

The recursion has something to do with theme_data_ui_create_form() from line 905 below it, see need help to theme a form in drupal 7 [solved].

Rewrote the patch a bit, also since data|contrib depends on ctools|contrib, might be better to use ctools multiform multi-step form instead.

Er, that's just a suggestion, it is not in the patch, dunno how yet.

Set to need review.

Thanks!
I added missing full stops at the end of one or two comments and added a couple of comments of my own, including this:

  // The table name is sanitized by the DataTable constructor.
  if (isset($form_state['storage']['name']) && data_get_table(trim($form_state['storage']['name']))) {

which I felt needed saying :)

- #1365346 by kanani, dozymoe: Fixed error messages in Create new table multistep form.