i18n multilingual support [#136551]

Currently, when creating a translation between two video nodes, that use the same video file, a duplicate node error is shown. This is due to video module node validation that checks if the path is already in use by another video node. To allow for multiple nodes with the same file, but different languages, the db_query should be changed. I am providing a patch that I believe solves this problem.

There is one caveat: if you have a translated version of the node already, you cannot create a node that has no language selected - you must select a language. I don't see that this should be a problem, as it would be illogical to have one node with a language and another of the same video, without a language selected.

Comment	File	Size	Author
#4	video-validate.patch	1.06 KB	davemybes
	video-i18n.patch	991 bytes	davemybes

Comments

Comment #1

fax8 commented 16 April 2007 at 06:30

Thanks for pointing this out.

Actually we already fixed this problem on 5.x version http://drupal.org/node/117580
and our approach was to simply remove that check.

I think that we should keep the same approach also for 4.7.
What is your opinion about this?

Comment #2

davemybes commented 17 April 2007 at 13:34

Thanks for pointing out the 5.x fix. Actually I hadn't thought about removing the check completely. Thinking about it now, I agree that allowing any number of nodes with the same link might be the best way to go. It allows for the largest number of usage scenarios. I'll test that out on my system and re-roll the patch for 4.7 if all goes well.

Comment #3

fax8 commented 28 April 2007 at 11:52

Status:

Needs review

» Needs work

Ok. Waiting for a 4.7 patch if you are able to provide it. Thanks.

Comment #4

davemybes commented 28 April 2007 at 19:24

Status	File	Size
new	video-validate.patch	1.06 KB

Patch for 4.7 to remove duplicate filename check in validate function is attached. Made against v1.52.2.9 2007/04/11 11:51:48. Everything seems to work fine without this check.