i18n multilingual support
incrn8 - April 15, 2007 - 20:49
| Project: | Video |
| Version: | 4.7.x-1.x-dev |
| Component: | Code |
| Category: | feature request |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | closed |
Description
Currently, when creating a translation between two video nodes, that use the same video file, a duplicate node error is shown. This is due to video module node validation that checks if the path is already in use by another video node. To allow for multiple nodes with the same file, but different languages, the db_query should be changed. I am providing a patch that I believe solves this problem.
There is one caveat: if you have a translated version of the node already, you cannot create a node that has no language selected - you must select a language. I don't see that this should be a problem, as it would be illogical to have one node with a language and another of the same video, without a language selected.
| Attachment | Size |
|---|---|
| video-i18n.patch | 991 bytes |
#1
Thanks for pointing this out.
Actually we already fixed this problem on 5.x version http://drupal.org/node/117580
and our approach was to simply remove that check.
I think that we should keep the same approach also for 4.7.
What is your opinion about this?
#2
Thanks for pointing out the 5.x fix. Actually I hadn't thought about removing the check completely. Thinking about it now, I agree that allowing any number of nodes with the same link might be the best way to go. It allows for the largest number of usage scenarios. I'll test that out on my system and re-roll the patch for 4.7 if all goes well.
#3
Ok. Waiting for a 4.7 patch if you are able to provide it. Thanks.
#4
Patch for 4.7 to remove duplicate filename check in validate function is attached. Made against v1.52.2.9 2007/04/11 11:51:48. Everything seems to work fine without this check.
#5
#6
#7
Automatically closed -- issue fixed for 2 weeks with no activity.