Hi:

With this proposed patch the main modifications are:

* Correct indentation (using 2 characters and spaces)
* Remove trailing spaces
* Fix several comments
* The inline CSS is now generated in the litejazz_preprocess_html()
* Optimization of the inline CSS
* Introduce the use of drupal_add_css() to handle the insertion of the inline CSS
* The conditional JS is included using a renderable array and invoking some official functions like:
- drupal_pre_render_conditional_comments()
- theming thru theme_html_tag()
- file_create_url() instead of using $GLOBALS['base_url']
* Other minor details

After this set of patches (6), at least my Coder is only reporting 3 critical warnings (discarding 38 normal warnings related to the .info file). 2 related with the .js files (I guess this two files will have to be rewriten) and another related to the hook_block() in the template.php file that I'm not able to understand.

HTH

MyXelf

CommentFileSizeAuthor
#1 litejazz-1365526-template-php-1-d7.patch8.65 KBmyxelf

Comments

myxelf’s picture

myxelf commented
Status: Active » Needs review
StatusFileSize
new litejazz-1365526-template-php-1-d7.patch8.65 KB

Attaching the patch and changing the status...

kisugiai’s picture

kisugiai commented

what does it you tell in the js files? bcause i don't see sowaht except the 10 lines in the pickstyle css
the message of info file you can ignore
btw i havent run coder because its does not raly runn on my demo pages and the themes newsflash, litejazz and tapestry are not runs throgh the coder only whitejazz and whitejazz was clean

myxelf’s picture

myxelf commented

3 critical warnings, 38 normal warnings, 0 warnings were flagged to be ignored

pickstyle.js
    severity: critical - Line -1: JavaScript should be compatible with other libraries than jQuery. (http://drupal.org/node/224333#javascript_compatibility)

suckerfish.js
    severity: critical - Line -1: JavaScript should be compatible with other libraries than jQuery. (http://drupal.org/node/224333#javascript_compatibility)

template.php
    severity: critical - Line 102: hook_block has been split into a number of smaller hooks. (http://drupal.org/node/224333#remove_op)
    function litejazz_preprocess_block(&$variables) {

The other 38 can be discarded as I said before

kisugiai’s picture

kisugiai commented

okay java try to put the code of js files in this code tag 

(function ($) {  
// Original JavaScript code.
})(jQuery);

with the block there i will look on the weekend may by its is a simple names change of function

myxelf’s picture

myxelf commented

I already tried that with pickstyle.js, and it didn't work. I think you will have to write those 2 files using the "jQuery-way" making use of the Drupal's behaviors and attaching functions to the DOM elements thru the use of selectors, etc.

BTW, the file ie6.css is orphan in the theme.

kisugiai’s picture

kisugiai commented

Hm okay ie6.css ist at the moment orphan thats right.
May I should remove becaus who's using ie6?
If we remove ie6 then we can remove suckerfish.js to.
Ie6/7 I wont support because its very horible to make it compatible with it so i think i will remove this in the next release.

btw: If you want look the whitejazz in this I haven't get an error by coder for js and iam not so firm in js scripting.

myxelf’s picture

myxelf commented

I would remove it since the day it was alive! :-D But maybe you should open a poll or do some research inside Drupal to see what is the policy about browsers' support. Quickly I found this

* http://groups.drupal.org/node/18456
* http://www.w3schools.com/browsers/browsers_stats.asp
* http://www.w3schools.com/browsers/browsers_explorer.asp

I think that 1% is a lot of people, but what we are removing is the suckerfish part which is considered into the B-graded level. The ie6.css would be the most determinant thing to remove and is already orphaned. OTOH ie.css is only talking about 1 padding-pixel. Taking all this into account, I would remove all the support from such a PITA-Browser.

I'll check the WhiteJazz theme at first chance.

kisugiai’s picture

kisugiai commented

so i have locked at the js and block messeages under coder
but dosent metter about this messages

the java messages i'm not sure but I think you can ignore it because we have not a module
the block message is a fault of coder because coder attaches modules information to the theme preprocesses
you can ignore it

little hint
dont swicht turn on the Converting 6.x modules to 7.x funktion this you dont need because we have a theme and the theme ist already D7.
eg if you check bartik with this filter you get some messages to of critical mesages

so now i will check somthing an look waht i use some things are good some ar unneccecary

kisugiai’s picture

kisugiai commented
Status: Needs review » Closed (fixed)

The templates.php is in the actual Dev in.
java won't fix