Closed (won't fix)
Project:
Drupal.org security advisory coverage applications
Component:
module
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
9 Dec 2011 at 09:45 UTC
Updated:
17 Dec 2011 at 22:33 UTC
Description: Hides the Toolbar module from user 1, so that user 1 (developer, themer, configurator) can use the admin_menu module without clashing with Toolbar, while keeping Toolbar active and visible for other users.
Sandbox: http://drupal.org/sandbox/leanderlindahl/1365822
Drupal core version: 7.x
Comments
Comment #1
klausiComment #2
patrickd commentedThis is a very, very small module^^
I really don't know if this is enough to grant you full project access, I'd rather suggest you trying that with a little more complex module.
Anyway, the few lines your module got - have some coding standart issues ;-)
(See here: http://ventral.org/pareview/httpgitdrupalorgsandboxleanderlindahl1365822git)
your .module file should be lowercase, as well as the all functions in your module
your using the master branch instead of a version specific one (for more information see the link above)
8 lines of code... ? really, please create a bigger one so we can review your coding skills seriously.
Comment #3
jthorson commentedI have to agree ... there is not enough code here to peform an adequate review.
If two modules are clashing, then perhaps this should be supplied as a patch to one of those modules in order to address the clash? Also, considering that this functionality is likely already available with Administration Menu Select, I'm going to mark this as a 'won't fix'.
I'm not trying to discourage your contribution, and feel free to reset to 'needs review' if you don't agree with the decision ... but I simply don't see how we can perform a true evaluation on what is essentially four lines of code.
Comment #4
leanderl commentedI didn't realize it was about showing coding skills, then I should probably just keep any code i produce to myself. This fixes a problem I've had since Drupal 7 introduced the Toolbar. I posted this code for use in the template.php in my blog and someone said "hey, it should be a module or you will still have the problem when switching from custom theme to Seven in the backend", which was true, so I made a module and wanted to share it through Drupal.org. I didn't realize it was about coding BIG modules and showing off your skills. I am clearly in the wrong place and misinterpreted what the Drupal project is about.
"8 lines of code... ? really, please create a bigger one so we can review your coding skills seriously."
Comment #5
patrickd commentedTHIS (the application process) is about showing us your coding skills
because, once you got through this process you also gained the permission to create any other full project
So we have to be shure that anybody with the permission to create FULL projects really knows how to code good and secure drupal modules
There is nothing against hosting a small module on drupal.org!
So, if you want to make your module a full project, we have to review your coding skills through a module with more functionality.
After we think you can do it, you are allowed to put any other (good & secure) module on drupal.org (no matter how small it is)
Comment #6
leanderl commentedOkay, so I am in the wrong place, as I said. If I someday become a programmer instead of a designer and write a big piece of awesome code I will get back to you.
Comment #7
patrickd commentedYour very welcome!
Comment #8
jthorson commentedleanderl,
Incidently, the goal wasn't to turn you off of contributing to Drupal ... my comments above were simply to indicate that the code supplied didn't meet the requirements of this particular project application process. That's not the same as saying it doesn't meet the requirements to be a full module (though in this case, you would have to educate me on how your module differs from admin_menu_select to say for sure).
However, this application process does accept more than just modules ... as a designer, if you had a custom theme that you wanted to submit, that could also be used to gain the 'create full projects' permission ... after which you could create any projects you wanted (module or theme) without restriction or review.
The 'without review' piece is the main reason that this process exists ... It's basically a 'sanity check' to ensure that the code being contributed meets some minimum standard for the Drupal contrib repositories; and to validate that the applicant has taken the time to preview the recommended documentation and reading for Drupal contributors. I'm also not saying that you haven't done the reading ... only that it is impossible to tell (as a reviewer) based solely on the code submitted with this project.
I'd encourage you to not let this setback discourage you from future contributions ... the process is about more than showing your 'coding' skills; theme designers are certainly welcome as well.
Comment #9
dave reidNote that there is already a module for this purpose that works with multiple admin menu modules: http://drupal.org/project/admin_select.