Comments

jdanthinne’s picture

Status: Active » Needs work

Interesting idea. Will have a look at how I can manage that.

jdanthinne’s picture

Status: Needs work » Needs review

Ok, I've taken all the work I've done for the support of Media Fields and adapted it to Field Collection, and it seems to be working fine…
Please download the next DEV version or use this patch : http://drupalcode.org/project/field_slideshow.git/patch/82e4fb0.
Tell me if it's working on your side.

perisdr’s picture

I am using the 7.x-1.x-dev version and it does not seem to work very well with field_collection.
I have a simple field_collection with two fields: An image and a text caption. Both fields support unlimited values. When I set the display of my field_collection to Slideshow I easily select my image field from the dropdown menu but it does not seem to work. I get no slideshow in my node. Just the first image.

Is there any way I can provide you with more information to fix it? This module is exactly what I need and I would love to make this work!

jdanthinne’s picture

@perisdr : do you have a test server where I can see the field collection definition?
Is the text caption a normal text field?
What is the version of field_collection?

perisdr’s picture

StatusFileSize
new46.98 KB

Using Field collection 7.x-1.x-dev
You were right about the caption. I used a "Long text" field. Just added a simple "Text" field and the it showed up in the dropdown list. But I still don't get any animation. The slideshow only shows my first picture, at least the caption now does show up correctly.

perisdr’s picture

Still can't figure how to make this work. Anyone had any success with Slideshow and Field Collection? I upgraded Field Collection to 7.x-1.0-beta3 in case it would take care of the warnings:

  • Warning: Invalid argument supplied for foreach() in file_field_widget_submit() (line 754 of C:\xampp\htdocs\sitename\modules\file\file.field.inc).
  • Warning: array_values() expects parameter 1 to be array, null given in file_field_widget_submit() (line 761 of C:\xampp\htdocs\sitename\modules\file\file.field.inc).

The warnings still persist in the 7.x-1.0-beta3. Could these errors be the cause why slideshow wont work? Other than that my configuration is extremely simple. One field collection containing one image and one caption field.

perisdr’s picture

Ok, I got it working. Feel kinda dump but I will share it so in case anyone else who has the same way of thinking can solve it.

My previous configuration:
One field_collection named Images&Captions. Number of values: 1
The Images&Captions contains:

  • Image field. Number of values: Unlimited
  • Caption field. Number of values: Unlimited

Now the correct way to make it work is:
One field_collection named Images&Captions. Number of values: Unlimited
The Images&Captions contains:

  • Image field. Number of values: 1
  • Caption field. Number of values: 1

which is the correct object oriented way of thinking...For some weird reason I liked more the first approach of uploading all your images and then inputing all your captions.

jdanthinne’s picture

Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

pacome’s picture

Status: Closed (fixed) » Needs work

Hello

In my case it works well with a text-field as a caption, but it doesn't work with a text-area (useful for a html caption, or a long description)...
Does anyone experience the same problem ?

Regards
-p-

ficklecat’s picture

Status: Needs work » Needs review
StatusFileSize
new683 bytes

I can confirm it does not work with text area (Long Text) selected as the field type for a Caption type field. Attached is a patch to include 'Long Text' and 'Long Text with Summary' support

pacome’s picture

Status: Needs review » Reviewed & tested by the community

The patch worked great for me !
Thank you very much

regards
-p-

kbasarab’s picture

I stumbled upon this thread looking for this same type support but for my use case I was using an image field with the Media File Selector widget.

I'd added a caption field to the File type via:
admin/structure/file-types/manage/image/fields

Even with the above patch for field collections this wasn't showing as an option. I patched by supported the field type of image as well adding onto the patch found here.

Attached is my version. If this should be in its own issue then I can move it but figured since it was an addon to the patch in #11 it would work here.

kbasarab’s picture

Status: Reviewed & tested by the community » Needs review

Changing back to needs review.

megan_m’s picture

Just confirming that the patch in #11 worked for me.

However, when I read that this module includes support for field collection, I assumed it would bring in the whole field collection (as you can do with any fields in Views Slideshow), not just a photo and caption(text) field.

Anonymous’s picture

I have tested the patches attached to #11 and #13 and they both work fine in a D7.15 installation with field_collection 7.x-1.0-beta4 and field_slideshow 1.7.

Anonymous’s picture

Hi Drupalchick,

if you mean support for rendering the entity in different view modes, there is a issues for that as well. It needs some testing! #1634412: Rendering entire entity

idflood’s picture

Status: Needs review » Needs work
StatusFileSize
new2.69 KB

Here is a rerolled version of the patch in 13 with a little addition in field_slideshow_field_formatter_settings_summary. I hope I didn't made any mistake when doing the reroll, but I first tried with 'normal' image field. The image field had the "alt" enabled, the caption worked without the patch. With the patch the caption settings show "Nothing" instead of the "Title text" and "Alt text" options.

abx’s picture

#11 works for me to use Long Text as a caption

Thanks

shadcn’s picture

Status: Needs work » Needs review

#11 works for me as well. (with 7.x-1.8)

@idflood, I tested patch in #18. It's breaking formatter settings.

idflood’s picture

Title: Integration with field collection » Field collection: caption from long text field
Status: Needs review » Needs work
csedax90’s picture

with the latest version, the patches above doesn't works

grasmash’s picture

Issue summary: View changes
Status: Needs work » Needs review
StatusFileSize
new984 bytes

Rolled simpler version against 7.x-1.82.

ficklecat’s picture

Please note the patch in #23 is identical to #11 which has been reviewed several times already.

sgurlt’s picture

#11 workes for me perfectly, thanks for the patch. Could it be comitted to the newest dev release?

sgurlt’s picture

Retested #13 as well and it works fine !

pacome’s picture

Tested patch #23, it seems to work perfectly.
Thanks !

ec-mdecker’s picture

Issue summary: View changes

#23 works, unless a user would like to have a link within the long text field as well. If a user includes a link within the long field, the slide link will not continue through the rest of the text. It will be ended at the beginning of the first link.

joelstein’s picture

Status: Needs review » Reviewed & tested by the community

Patch in #23 works great!

hailu’s picture

This is awesome, thanks guys!!

m1n0’s picture

Works great, please commit to next release.

  • jdanthinne committed 82e4fb0 on 8.x-1.x
    [#1366226] : added support for Field Collection
    
    
ficklecat’s picture

Version: 7.x-1.x-dev » 7.x-2.x-dev
Status: Reviewed & tested by the community » Needs review
StatusFileSize
new1.21 KB

It looks like work has stopped on the 7.x-1.x branch #2448319: [META] New release 7.x-2.0

Re-rolling patch against 7.x-2.x branch

  • jdanthinne committed 82e4fb0 on 8.x-2.x
    [#1366226] : added support for Field Collection
    
    
chegor’s picture

Status: Needs review » Reviewed & tested by the community

Confirming #23 works with 7.x-1.82

lamp5’s picture

Status: Reviewed & tested by the community » Closed (outdated)