Commerce Moneris

Your module has some coding style issues, see http://ventral.org/pareview/httpgitdrupalorgsandboxionutalexuc1355770git. You can use this site to resolve those findings. If you got any questions on that, please ask!
edit: As I see you've already used the service, so do you have problems resolving the rest of the issues?

Review of the 7.x-1.x branch:

Run coder to check your style, some issues were found (please check the Drupal coding standards):

Severity minor, Drupal Commenting Standards, Internationalization, Drupal Security Checks, Drupal SQL Standards, Drupal Coding Standards
sites/all/modules/pareview_temp/test_candidate/commerce_moneris.module:
+147: [minor] in most cases, replace the string function with the drupal_ equivalent string functions

Status Messages:
Coder found 1 projects, 1 files, 1 minor warnings, 0 warnings were flagged to be ignored

Drupal Code Sniffer has found some code style issues (please check the Drupal coding standards):
FILE: ...iew/sites/all/modules/pareview_temp/test_candidate/commerce_moneris.inc
--------------------------------------------------------------------------------
FOUND 56 ERROR(S) AND 1 WARNING(S) AFFECTING 55 LINE(S)
--------------------------------------------------------------------------------
22 | ERROR | Parameter comment indentation must be 2 additional spaces at
| | position 1
24 | ERROR | Parameter comment indentation must be 2 additional spaces at
| | position 2
26 | ERROR | Parameter comment indentation must be 2 additional spaces at
| | position 3
28 | ERROR | PHP4 style constructors are not allowed; use "__construct()"
| | instead
64 | ERROR | Parameter comment indentation must be 2 additional spaces at
| | position 1
66 | ERROR | Parameter comment indentation must be 2 additional spaces at
| | position 2
68 | ERROR | Parameter comment indentation must be 2 additional spaces at
| | position 3
70 | ERROR | Parameter comment indentation must be 2 additional spaces at
| | position 4
72 | ERROR | Parameter comment indentation must be 2 additional spaces at
| | position 5
141 | ERROR | Parameter comment indentation must be 2 additional spaces at
| | position 2
143 | WARNING | Private methods are discouraged, use protected methods instead
177 | ERROR | Parameter comment indentation must be 2 additional spaces at
| | position 1
179 | ERROR | Parameter comment indentation must be 2 additional spaces at
| | position 2
181 | ERROR | PHP4 style constructors are not allowed; use "__construct()"
| | instead
185 | ERROR | Spaces must be used to indent lines; tabs are not allowed
185 | ERROR | Line indented incorrectly; expected at least 8 spaces, found 5
191 | ERROR | Spaces must be used to indent lines; tabs are not allowed
191 | ERROR | Line indented incorrectly; expected at least 8 spaces, found 6
203 | ERROR | Parameter comment indentation must be 2 additional spaces at
| | position 1
250 | ERROR | PHP4 style constructors are not allowed; use "__construct()"
| | instead
286 | ERROR | Parameter comment indentation must be 2 additional spaces at
| | position 1
288 | ERROR | Parameter comment indentation must be 2 additional spaces at
| | position 2
291 | ERROR | Line indented incorrectly; expected 4 spaces, found 3
292 | ERROR | Line indented incorrectly; expected 6 spaces, found 5
293 | ERROR | Line indented incorrectly; expected 8 spaces, found 7
294 | ERROR | Line indented incorrectly; expected at least 10 spaces, found
| | 9
295 | ERROR | Line indented incorrectly; expected at least 10 spaces, found
| | 9
296 | ERROR | Line indented incorrectly; expected at least 10 spaces, found
| | 9
299 | ERROR | Line indented incorrectly; expected 8 spaces, found 6
300 | ERROR | Line indented incorrectly; expected at least 10 spaces, found
| | 8
301 | ERROR | Line indented incorrectly; expected at least 10 spaces, found
| | 8
302 | ERROR | Line indented incorrectly; expected at least 10 spaces, found
| | 8
305 | ERROR | Line indented incorrectly; expected 8 spaces, found 6
306 | ERROR | Line indented incorrectly; expected at least 10 spaces, found
| | 8
307 | ERROR | Line indented incorrectly; expected at least 10 spaces, found
| | 8
308 | ERROR | Line indented incorrectly; expected at least 10 spaces, found
| | 8
311 | ERROR | Line indented incorrectly; expected 8 spaces, found 6
312 | ERROR | Line indented incorrectly; expected 10 spaces, found 8
313 | ERROR | Line indented incorrectly; expected at least 12 spaces, found
| | 11
315 | ERROR | Line indented incorrectly; expected 10 spaces, found 8
316 | ERROR | Line indented incorrectly; expected at least 12 spaces, found
| | 10
318 | ERROR | Line indented incorrectly; expected 10 spaces, found 8
319 | ERROR | Line indented incorrectly; expected at least 12 spaces, found
| | 10
323 | ERROR | Line indented incorrectly; expected 8 spaces, found 6
324 | ERROR | Line indented incorrectly; expected 10 spaces, found 8
325 | ERROR | Line indented incorrectly; expected at least 12 spaces, found
| | 11
327 | ERROR | Line indented incorrectly; expected 10 spaces, found 8
328 | ERROR | Line indented incorrectly; expected at least 12 spaces, found
| | 10
330 | ERROR | Line indented incorrectly; expected 10 spaces, found 8
331 | ERROR | Line indented incorrectly; expected at least 12 spaces, found
| | 10
336 | ERROR | Line indented incorrectly; expected 4 spaces, found 3
337 | ERROR | Line indented incorrectly; expected at least 6 spaces, found 5
345 | ERROR | Parameter comment indentation must be 2 additional spaces at
| | position 1
347 | ERROR | Parameter comment indentation must be 2 additional spaces at
| | position 2
349 | ERROR | Parameter comment indentation must be 2 additional spaces at
| | position 3
375 | ERROR | Parameter comment indentation must be 2 additional spaces at
| | position 1
377 | ERROR | Parameter comment indentation must be 2 additional spaces at
| | position 2
--------------------------------------------------------------------------------

FILE: ...sites/all/modules/pareview_temp/test_candidate/commerce_moneris.install
--------------------------------------------------------------------------------
FOUND 0 ERROR(S) AND 1 WARNING(S) AFFECTING 1 LINE(S)
--------------------------------------------------------------------------------
9 | WARNING | Format should be * Implements hook_foo().
--------------------------------------------------------------------------------

FILE: .../sites/all/modules/pareview_temp/test_candidate/commerce_moneris.module
--------------------------------------------------------------------------------
FOUND 19 ERROR(S) AND 1 WARNING(S) AFFECTING 19 LINE(S)
--------------------------------------------------------------------------------
9 | WARNING | Format should be * Implements hook_foo().
9 | ERROR | Expected 2 space(s) before asterisk; 1 found
10 | ERROR | Expected 2 space(s) before asterisk; 1 found
55 | ERROR | Whitespace found at end of line
57 | ERROR | Parameter comment indentation must be 2 additional spaces at
| | position 1
59 | ERROR | Parameter comment indentation must be 2 additional spaces at
| | position 2
61 | ERROR | Parameter comment indentation must be 2 additional spaces at
| | position 3
63 | ERROR | Parameter comment indentation must be 2 additional spaces at
| | position 4
102 | ERROR | Extra newline found before function comment short description
106 | ERROR | Parameter comment indentation must be 2 additional spaces at
| | position 1
107 | ERROR | Missing parameter type at position 2
108 | ERROR | Parameter comment indentation must be 2 additional spaces at
| | position 2
110 | ERROR | Parameter comment indentation must be 2 additional spaces at
| | position 3
112 | ERROR | Parameter comment indentation must be 2 additional spaces at
| | position 4
114 | ERROR | Parameter comment indentation must be 2 additional spaces at
| | position 5
124 | ERROR | Missing parameter type at position 1
126 | ERROR | Missing parameter type at position 2
128 | ERROR | Missing parameter type at position 3
130 | ERROR | Missing parameter type at position 4
131 | ERROR | Parameter comment indentation must be 2 additional spaces at
| | position 4
--------------------------------------------------------------------------------

This automated report was generated with PAReview.sh, your friendly project application review script. Go and review some other project applications, so we can get back to yours sooner.
Source: http://ventral.org/pareview - PAReview.sh online service

@yasglobal please have a look at the "source" tab on the report, so you can change your comment to html format

@ionut.alexuc has been contacted to ask if the application is abandoned.

After ten weeks with a status of needs work: the applicant may be contacted by a reviewer to determine whether the application was indeed abandoned. The action taken by the reviewer should be documented in the project application issue.

http://drupal.org/node/894256

This module looks clean on a pareview, and seems to follow commerce's guidelines for writing a payment module.

Based on that, Im moving this to RTBC.

Would you like to take part in the review bonus program? I personally only review/approve applications with a review bonus, but of course you can also wait for other git administrators to take a look at your code.

That's great, just follow the instructions (http://drupal.org/node/1410826) and go ahead :)

Congratulations! You are now a "vetted" git user and can promote experimental sandboxes to full projects. And thank you further for diving into the review process yourself.

Thank you drupalnetworks, patrickd, and farald for your reviews.

Ey, I wannet to do that one ! :D

Some minor stuff that catched my eye:

1. Please take a moment to make your project page follow tips for a great project page.
2. Please take more care about your commit messages, as "new fixes" or "break" don't really tell me what you were doing.
3. By using space-indenting you could make your readme better structured.
4. Meanwhile the drupalcs scanner has enhanced and finds some new coding-style problems: http://ventral.org/pareview/httpgitdrupalorgsandboxionutalexuc1355770git
5. You got a configuration page -> you should add it as "configure = " parameter to your .info
6. variable_get('commerce_moneris_ssl', 0), You should always use TRUE or FALSE for booleans
7. if you use $result as array you should initialise it with $result = array(); and not NULL

Hey ionut.alexuc,

How much longer until you will be promoting this project?

Cheers,
Gene Bernier

It has been promoted already: http://drupal.org/project/commerce_moneris