Download & Extend

Cleaning Code with coder

Project:Group Admin
Version:6.x-2.2-beta1
Component:Code
Category:task
Priority:normal
Assigned:Unassigned
Status:active
Issue tags:potx

Issue Summary

Hi,

i saw many errors for groupadmin, so i started with a coder session to clean the minimal errors and make the code easier to read.

still missing:

  • Line -1: @file block missing (in the moment i do not have the time to add these blocks)
  • change the sql - queries in a way coder does not see a possible security problem in them (which is not right for a few examples i checked)
  • better usage of t(), so all strings are translateable via http://localize.drupal.org

Comments

#1

here the first patch

AttachmentSize
coder_cleanup-1367690-1.patch 64.3 KB

#2

Thanks for your work Thomas. If we can get some positive feedback I'll do a commit.

nobody click here