The Regions API generates 2999 PHP notices when running the SimpleTest cases. See the testbot log at http://qa.drupal.org/pifr/test/184794.

It is easy to fix these PHP notices with a very small patch, which I've attached.

CommentFileSizeAuthor
PHP-Notices.patch1012 bytestr

Comments

Scyther’s picture

Scyther commented
Status: Needs review » Fixed

Thanks for the help! http://drupalcode.org/project/countries_api.git/commit/12d89c5

tr’s picture

tr commented
Status: Fixed » Needs review

@Scyther: That commit didn't commit my patch, it committed a small part of the patch in #1367980: Coding standards.

The PHP notices are not fixed.

Scyther’s picture

Scyther commented
Status: Needs review » Fixed

TR, you are right. I commited the wrong file, I was a bit tired I think.

Now I commited the changed regions_api.module file so now it should be right, please confirm. http://drupalcode.org/project/countries_api.git/commit/196c602

tr’s picture

tr commented

Yup, that fixed the PHP notices. You see that the Country codes API tests run green at http://drupal.org/node/200548/testing-status.
Thanks!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.