Currently the facetapi.callbacks.inc file is sourced on every page load. I we moved the require_once call to the FacetapiAdapter::processFacets() method, the file will only be sourced when necessary.

CommentFileSizeAuthor
#3 facetapi-1368690-3.patch1.21 KBcpliakas
#1 facetapi-1368690-1.patch1.22 KBcpliakas

Comments

cpliakas’s picture

cpliakas commented
Status: Active » Needs review
StatusFileSize
new facetapi-1368690-1.patch1.22 KB

Attached patch makes the change.

cpliakas’s picture

cpliakas commented
Status: Needs review » Needs work

Hm... This patch seems to break the "Post date" facet.

cpliakas’s picture

cpliakas commented
Status: Needs work » Needs review
StatusFileSize
new facetapi-1368690-3.patch1.21 KB

Attached patch places the require_once call in the Facetapiadapter::addActiveFilters() method, which runs earlier.

cpliakas’s picture

cpliakas commented
Status: Needs review » Fixed

Resolved in commit http://drupalcode.org/project/facetapi.git/commit/a17defd.

nick_vh’s picture

nick_vh
he/him
Location Ghent
commented

Why don't you use module_load_include?

cpliakas’s picture

cpliakas commented
Status: Fixed » Needs work

Because I am sleep deprived.

cpliakas’s picture

cpliakas commented
Status: Needs work » Fixed

Good catch, Nick. Follow up commit at http://drupalcode.org/project/facetapi.git/commit/1c1dca0.

Automatically closed -- issue fixed for 2 weeks with no activity.