Can I add any views [#1368864]

Comment #1

Prague man commented 12 December 2011 at 21:10

sorry, if you have use vbo views, must write this function e.g.:
print views_embed_view("commerce_vbo_views_orders", "block_1", $order->order_number);

instead:
print views_embed_view("orders", "block_1", $order->order_number);

Log in or register to post comments

Comment #2

essbee commented 13 December 2011 at 20:26

I think mpark has highlighted a massive opportunity to greatly improve the flexibility of this module without having to do any heavy lifting.

Rather than have the default template have a hard coded order detail table as it does currently, the module could include a View that is embedded in the email. This view can then be overridden/modified by end users who arent comfortable with code.

This would greatly increase the flexibility, and alleviate issues raised in other issues, such as the hard coded styling issues (http://drupal.org/node/1332698). People would no longer need to hack the module, and further they can include any custom product attributes, currency styling etc will also be properly handled (at present it doesnt pass through commerce_currency_format so doesnt pick up the proper currency formatting).

I think this path is far more aligned to the general approach of Commerce in maximising the use of views to display information and thus allow easy end user overriding.

All that would be required to implement this is to remove the entire

html from commerce-order-email.tpl.php and replace with

 print views_embed_view("order_invoice_detail", "block_1", $order->order_number);

A default view named order_invoice_detail or similar would then be provided by the module.

Thoughts?

Log in or register to post comments

Comment #3

essbee commented 14 December 2011 at 03:17

Hmma major stumbling bog for this may be permissions.

If a user is not logged in and processes an order, the view wont be able to access order information as anonymous can't view orders (for obvious reasons).

Any thoughts?

Log in or register to post comments

Comment #4

Darren Shelley commented 2 May 2012 at 19:20

I would love to see this feature. It would be far easier to override and add fields which are not core to commerce line items.

essbee:- I'm not in a position to test, but from memory a fielded view with "disable sql rewriting" should be sufficient to bypass access issues. So long as the view does not declare a page it shouldn't really throw up any security issues, as this module would be the only point of execution.

If someone undertakes this i recommend highlighting the security issue in the description of the module, to prevent accidentally creating it as a page.