"Top search phrases with no results" not work if facetapi turned on [#1368926]

We have problem with report "Top search phrases with no results" (no results).

In this code (in apachesolr_stats_generate_report_elements):

// Count keywords with zero results; but only when no filters issued.
if ($record->numfound == 0 && (!$record->filters)) {
 @$keywords_noresults[$keys_filtered]++;
}

variable $record->filters is set to 'a:0:{}'. May code should look like this:

// Count keywords with zero results; but only when no filters issued.
if ($record->numfound == 0 && (!$record->filters || $record->filters == 'a:0:{}')) {
 @$keywords_noresults[$keys_filtered]++;
}

Comment	File	Size	Author
#2	zero-results-1368926-2.patch	1.6 KB	cpliakas

Comments

Comment #1

cpliakas commented 18 May 2012 at 21:39

Status:

Needs review

» Needs work

Instead of testing for the string, it might be useful to unserialize the array since it is already done in that loop once. We could unserialize it at the top of the loop, store it in a variable, and then use the variable in both places.