Request to have the Layer Switcher be uncollapsed on load as an option in Behaviors.

CommentFileSizeAuthor
#7 openlayers-1369074-5-20beta1.patch2.36 KBElvar
#5 openlayers-1369074-5-2.x.patch2.36 KBElvar
#5 openlayers-1369074-5-2.x.patch2.28 KBElvar
#2 openlayers-1369074-2.patch2.3 KBbleedev
#1 openlayers-1369074-1.patch2.25 KBbleedev

Comments

bleedev’s picture

bleedev commented
StatusFileSize
new openlayers-1369074-1.patch2.25 KB

Patch for this request.

bleedev’s picture

bleedev commented
StatusFileSize
new openlayers-1369074-2.patch2.3 KB

Updated to read collapsed instead of hide.

mtoscano’s picture

mtoscano commented

Can this patch also work on 7.x-2.0?

mtoscano’s picture

mtoscano commented

OK, I tested it and the lines of code to add are the same, but the patch should be rewritten because in the 7.x-2.0 version the files to patch are in different location and the .js looks quite different.

Elvar’s picture

Elvar commented
Status: Active » Needs review
StatusFileSize
new openlayers-1369074-5-2.x.patch2.28 KB
new openlayers-1369074-5-2.x.patch2.36 KB

Here's the changes from #2 rerolled against 7.x-2.0beta1 as well as 7.x-2.x.

Status: Needs review » Needs work

The last submitted patch, openlayers-1369074-5-HEAD.patch, failed testing.

Elvar’s picture

Elvar commented
Version: 6.x-2.0-alpha10 » 7.x-2.0-beta1
Status: Needs work » Needs review
StatusFileSize
new openlayers-1369074-5-20beta1.patch2.36 KB

Patch was testet against branch OpenLayers - 6.x-2.0-alpha10.

The patch against 7.x-2xbeta1

mgifford’s picture

mgifford
he/him
Primary language English
commented

Patch applies to the dev version too. Just note this concern about the patch:

/DRUPAL7/sites/all/modules/openlayers/plugins/behaviors$ patch openlayers_behavior_layerswitcher.inc < openlayers-1369074-5-20beta1_0.patch
patching file openlayers_behavior_layerswitcher.inc
patching file openlayers_behavior_layerswitcher.js
patch unexpectedly ends in middle of line

zzolo’s picture

zzolo commented
Status: Needs review » Fixed

Committed to D7:
http://drupalcode.org/project/openlayers.git/commit/8aa277f

It makes much more sense to have this as "Maximize by Default" so I changed things around a bit.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.