Download & Extend
OpenLayers » Issues

Create behavior for allowing the Layer Switcher to be un-collapsed

Posted by bleedev on December 12, 2011 at 11:59pm
Project:OpenLayers
Version:7.x-2.0-beta1
Component:OL Behaviors
Category:feature request
Priority:normal
Assigned:Unassigned
Status:closed (fixed)

Issue Summary

Request to have the Layer Switcher be uncollapsed on load as an option in Behaviors.

Login or register to post comments

Comments

#1

Posted by bleedev on December 13, 2011 at 12:04am

Patch for this request.

AttachmentSizeStatusTest resultOperations
openlayers-1369074-1.patch2.25 KBIdleFAILED: [[SimpleTest]]: [MySQL] Unable to apply patch openlayers-1369074-1.patch. Unable to apply patch. See the log in the details link for more information.View details

#2

Posted by bleedev on December 13, 2011 at 12:09am

Updated to read collapsed instead of hide.

AttachmentSizeStatusTest resultOperations
openlayers-1369074-2.patch2.3 KBIdleFAILED: [[SimpleTest]]: [MySQL] Unable to apply patch openlayers-1369074-2.patch. Unable to apply patch. See the log in the details link for more information.View details

#3

Posted by mato on February 7, 2012 at 8:23am

Can this patch also work on 7.x-2.0?

#4

Posted by mato on February 7, 2012 at 3:13pm

OK, I tested it and the lines of code to add are the same, but the patch should be rewritten because in the 7.x-2.0 version the files to patch are in different location and the .js looks quite different.

#5

Posted by Elvar on February 9, 2012 at 1:53pm
Status:active» needs review

Here's the changes from #2 rerolled against 7.x-2.0beta1 as well as 7.x-2.x.

AttachmentSizeStatusTest resultOperations
openlayers-1369074-5-20beta1.patch2.36 KBIdleFAILED: [[SimpleTest]]: [MySQL] Unable to apply patch openlayers-1369074-5-20beta1.patch. Unable to apply patch. See the log in the details link for more information.View details
openlayers-1369074-5-HEAD.patch2.28 KBIdleFAILED: [[SimpleTest]]: [MySQL] Unable to apply patch openlayers-1369074-5-HEAD.patch. Unable to apply patch. See the log in the details link for more information.View details

#6

Posted by System Message on February 9, 2012 at 1:55pm
Status:needs review» needs work

The last submitted patch, openlayers-1369074-5-HEAD.patch, failed testing.

#7

Posted by Elvar on March 1, 2012 at 2:29pm
Version:6.x-2.0-alpha10» 7.x-2.0-beta1
Status:needs work» needs review

Patch was testet against branch OpenLayers - 6.x-2.0-alpha10.

The patch against 7.x-2xbeta1

AttachmentSizeStatusTest resultOperations
openlayers-1369074-5-20beta1.patch2.36 KBIdlePASSED: [[SimpleTest]]: [MySQL] 236 pass(es).View details

#8

Posted by mgifford on March 13, 2012 at 4:33pm

Patch applies to the dev version too. Just note this concern about the patch:

/DRUPAL7/sites/all/modules/openlayers/plugins/behaviors$ patch openlayers_behavior_layerswitcher.inc < openlayers-1369074-5-20beta1_0.patch
patching file openlayers_behavior_layerswitcher.inc
patching file openlayers_behavior_layerswitcher.js
patch unexpectedly ends in middle of line

#9

Posted by zzolo on March 22, 2012 at 5:00pm
Status:needs review» fixed

Committed to D7:
http://drupalcode.org/project/openlayers.git/commit/8aa277f

It makes much more sense to have this as "Maximize by Default" so I changed things around a bit.

#10

Posted by System Message on April 5, 2012 at 5:10pm
Status:fixed» closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.