Not sure if this is a Views or VBO issue.

1) Create a new view of type User
2) Set it up for VBO, any action will do
3) Add a field "username", make sure to UN-CHECK "Link to user"

Now, try to perform an action on the view. It seems to fail because "uid" is not in the resultset, and the loader from hook_vbo_object_info does not return anything.

If you check "link to user" and try it again, it works, because in order to grab the UID, it is added to the result set.

I have a feeling this is views, but wanted to post it here first.

Tested with Views 6.x-3.x and VBO 6.x-1.x

Comments

bojanz’s picture

bojanz commented

Yeah, Views 3 changed the logic around adding the base field, so now VBO needs to do that explicitly (currently it doesn't, hence your problem).

djdevin’s picture

djdevin
he/him
Primary language English
Location Philadelphia
commented

Thanks for clarifying that, we had a bunch of views coming from 6.x-2.x that broke. Is this something VBO is going to take care of or should we assume that the base field has to be added by some other means?

bojanz’s picture

bojanz commented

This is something that should be fixed in VBO.

djdevin’s picture

djdevin
he/him
Primary language English
Location Philadelphia
commented

Is that a request for a patch :) We have a lot of views we'd rather not change, and we have some time to work on it.

bojanz’s picture

bojanz commented

I'm always happy to accept contributions :)

I'm guessing you need to add a query() method to views_bulk_operations_plugin_style.inc.
Here's the appropriate code in the row plugin (which doesn't get called since we don't use the row plugin. I wonder if just enabling that in views_bulk_operations_views_plugins() might do the trick):

  function query() {
    if (isset($this->base_table)) {
      if (isset($this->options['relationship']) && isset($this->view->relationship[$this->options['relationship']])) {
        $relationship = $this->view->relationship[$this->options['relationship']];
        $this->field_alias = $this->view->query->add_field($relationship->alias, $this->base_field);
      }
      else {
        $this->field_alias = $this->view->query->add_field($this->base_table, $this->base_field);
      }
    }
  }

And please confirm that the solution works with both Views 2 and Views 3.

I'll paste this issue to dereine on IRC when he comes online, he might have more tips, I haven't done the Views 2 -> Views 3 switch in a long time..

Thanks!

djdevin’s picture

djdevin
he/him
Primary language English
Location Philadelphia
commented

Great, I was thinking the same thing. Will do some testing.

djdevin’s picture

djdevin
he/him
Primary language English
Location Philadelphia
commented

This worked for us, stripped down to:

  function query() {
    if (!isset($this->view->query->fields[$this->view->base_field])) {
      $this->view->query->add_field($this->view->base_table, $this->view->base_field);
    }
  }

Not sure if there's any implications...checks if the base field is not present in the view, then add it. Need to do some exploratory testing in Views 2/3.

Edit: tested it against Views 2, and it seems to not do anything since the base field is already present.

infojunkie’s picture

infojunkie
Location Vancouver
commented
Status: Active » Fixed

I reproduced the original problem and verified that #7 did solve it. Committed to latest dev. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.