Media module manage file display settings don't play nice [#1369244]

There is some weird bug here, where on the manage file display settings for an audio media field (media module version 1.0-rc2) throws this error:

Notice: Undefined variable: link_types in mediaelement_field_formatter_settings_form() 
(line 201 of /Users/.../sites/all/modules/contrib/mediaelement/mediaelement.module).

And the formatter setting's vertical tabs are all duplicated and just generally munted.

Let me know if there's anything I can explain further or help with.

Cheers

Comment	File	Size	Author
#1	fix_settings_form-1369244-1.patch	1.3 KB	gollyg
	munted-mediaelement-tabs.png	56.54 KB	jptaranto

Comments

Comment #1

gollyg commented 1 January 2012 at 07:32

Status:

Active

» Needs review

Status	File	Size
new	fix_settings_form-1369244-1.patch	1.3 KB

There are two issues here:

* The undefined link type
* The munged settings form

Both issues appear to have been fixed in 7.x-2.x. I don't know if they will be backported.

Both issues were created in the settings form function:

mediaelement_field_formatter_settings_form

The first was simply and undefined variable on a textfield and is dealt with here http://drupal.org/node/1170536

The second was that the form was returning the original form plus modifications. This has been dealt with by changing the name of the form array to 'element'.

Have attached a patch against 7.x-1.1.