Reviewing the CCLI code for other differences in conjunction with #1369570: How is this module different from Commerce Custom Line Items (Types)?, I did notice two things that need to be done here:

  1. Add validation to prevent the same line item type from being used twice. (Actually, the machine-name widget itself already takes care of this. No need to add it ourselves.)
  2. Notify the field system properly w/ field_attach_create_bundle() / field_attach_delete_bundle(). I didn't even know these existed, and I'm guessing we'll need to update the core Product UI module to use these as well.

Comments

rszrama’s picture

Title: Two items from CCLI that need to be included » Implement the field attach functions for bundles
Category: bug » task

Ok, apparently the strike tag doesn't work on d.o for me, but item 1 no longer applies. We don't need to validate this ourselves; the machine-name widget does it all on its own accord.

We still should use the field attach functions, even though they don't do anything for the SQL back end.

rszrama’s picture

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

Anonymous’s picture

Issue summary: View changes

Strike out item 1.