Closed (duplicate)
Project:
Commerce Shipping Flat Rate
Version:
7.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
13 Dec 2011 at 16:01 UTC
Updated:
14 Dec 2011 at 23:26 UTC
Hi,
I am using the flat rate module for an i18N store.
I configured the English labels (and line item labels) in my shipping rules but I cannot translate them through the UI
I guess CommerceShippingFlatRate.class.php : line 179 should be OK
'label' => t($settings['label']),
cheers
Dimitris
Comments
Comment #1
rszrama commentedYou're actually using the Flat Rate module designed for Shipping 1.x, not this module. That said, t() shouldn't be used to translate string literals. It's fine for your private usage, but modules shouldn't be including code like this.
Comment #2
jimkont commentedThanks for the info! (and the correction:)
Anyway, I'll go my-way for now, but if you want commerce to support multilingual sites this has to be resolved somehow...
Dimitris
Comment #3
rszrama commentedWe're always open to solutions that don't abuse the API. I know there are modules out there for handling this sort of thing, but I don't have any experience with them. If you research them and recommend a solution, that will go a long way toward resolving the issue for everyone. : )
Comment #4
rszrama commentedMarking this a duplicate of #1369696: Support translatable Shipping labels for methods / services. See my comment #2 there for more info.