I am using the profile2 module and when I edit a profile page and save I get:

Notice: Undefined index: legal_accept in legal_user_update() (line 471 of /var/www/mirp/profiles/mirp/modules/contrib/legal/legal.module).

This is because the legal agreement checkboxes aren't on that page.

CommentFileSizeAuthor
#21 legal-undefined_legal_accept-1370302-21.patch743 bytesmaximpodorov
#7 legal-undefined_legal_accept-1370302-7.patch706 bytesrooby
#6 legal_undefined_legal_accept_rooby_schultwin2.patch712 bytesschultetwin
#4 legal_undefined_legal_accept_rooby_schultwin.patch839 bytesschultetwin
#2 legal_module_only_yourself.patch831 bytesschultetwin
#1 legal-undefined_legal_accept-1370302-1.patch467 bytesrooby

Comments

rooby’s picture

rooby commented
Status: Active » Needs review
StatusFileSize
new legal-undefined_legal_accept-1370302-1.patch467 bytes

Here is a patch to fix this.

schultetwin’s picture

schultetwin commented
StatusFileSize
new legal_module_only_yourself.patch831 bytes

Need to add another check. This patch should be applied as well.

rooby’s picture

rooby commented

You're right, that should be moved.

Although the patch should have the changes in both patches together in one patch.

schultetwin’s picture

schultetwin commented
StatusFileSize
new legal_undefined_legal_accept_rooby_schultwin.patch839 bytes

Patch rerolled.

rooby’s picture

rooby commented

Thanks for replying so fast, however I don't think I thought it through properly before.

I am going just by looking at the code at the moment but I think moving that piece of code is not the best idea.

If you are viewing someone else's account you can see the legal field but you cannot edit it (because a user can only agree for themselves). When it comes to save the page and do legal_user_update() those values are in the $edit variable.
So if it isn't the user account for the currently logged in user we want to clear the legal values as you cannot change someone else's legal agreements, which is what all the setting values to NULL is for. So my moving that if statement you are missing that step.

So I'd say this should be left as is, but if you really want it changed you should open a new issue as it would be separate to this one.

This issue should still be solved by the patch in #1.

schultetwin’s picture

schultetwin commented
StatusFileSize
new legal_undefined_legal_accept_rooby_schultwin2.patch712 bytes

Okay, I can accept that. But the issue is not solved by the first patch, I still received this specific error after applying this patch. This patch should fix it.

rooby’s picture

rooby commented
StatusFileSize
new legal-undefined_legal_accept-1370302-7.patch706 bytes

Ah I see now.

Here is the same patch with a slight change to avoid potential undefined variable messages.

schultetwin’s picture

schultetwin commented
Status: Needs review » Reviewed & tested by the community

Ah, much cleaner, thank you.

david387’s picture

david387 commented

rooby's patch in comment #7 worked great!

simon georges’s picture

simon georges commented

Closed #1473378: Notice: Undefined index: legal_accept in legal_user_update() (Zeile 470 von /Users/geraldpitschek/Sites/iuk20beta01/sites/all/mo as a duplicate of this issue.

itz_andr3’s picture

itz_andr3 commented

ignore

seworthi’s picture

seworthi commented

Patch in #7 worked great, but I also applied same code to "legal_user_login()" function.

benjf’s picture

benjf commented

#7 works for me also

thanks!

IWasBornToWin’s picture

IWasBornToWin commented

Has this patch been committed to the latest dev version?

simon georges’s picture

simon georges commented

@IWasBornToWin: no, it hasn't.

robert castelo’s picture

robert castelo commented
Status: Reviewed & tested by the community » Fixed

Thanks.

Patch #7 committed to dev

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

nicolasdiogo’s picture

nicolasdiogo commented

sorry for the bad news.

i have just updated my Drupal installation

and it has shown the above error.
drupal - 7.16

regards,

stevieb’s picture

stevieb commented

I also get the error with the update to 7.17

maximpodorov’s picture

maximpodorov commented
Status: Closed (fixed) » Active

The same fix as in #7 is required for legal_user_insert() function. Currently, creating users by Rules produces PHP notice:
Notice: Undefined index: legal_accept in legal_user_insert()

maximpodorov’s picture

maximpodorov commented
StatusFileSize
new legal-undefined_legal_accept-1370302-21.patch743 bytes

The patch for legal_user_insert() function.

maximpodorov’s picture

maximpodorov commented
Status: Active » Needs review
d0t15t’s picture

d0t15t commented

was having a similar error - this fixed it!

simon georges’s picture

simon georges commented
Status: Needs review » Reviewed & tested by the community
mrsimonelliott’s picture

mrsimonelliott commented

Patch in 21 good for me

spyderpie’s picture

spyderpie commented

I have the same issue .. is this in Dev yet?

julie

robert castelo’s picture

robert castelo commented
Status: Reviewed & tested by the community » Fixed

Fixed in dev with #21, will include in next release.

spyderpie’s picture

spyderpie commented

Thank you ;)

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.