Download & Extend

Remove Node from minimal profile

Project:Drupal core
Version:8.x-dev
Component:install system
Category:task
Priority:minor
Assigned:Xano
Status:needs work
Issue tags:DDU2012

Issue Summary

Once #375397: Make Node module optional gets in, we should remove Node.module form the minimal profile. User editable content is not always a desired feature, not does it prevent any WTFs, which is why Block or DBlog are part of the minimal profile.

AttachmentSizeStatusTest resultOperations
remove_node_from_minimal_00.patch391 bytesIdleFAILED: [[SimpleTest]]: [MySQL] Unable to apply patch remove_node_from_minimal_00.patch. This may be a -p0 (old style) patch, which is no longer supported by the testbots.View details | Re-test

Comments

#1

Status:needs review» needs work

The last submitted patch, remove_node_from_minimal_00.patch, failed testing.

#2

Component:rdf.module» profile.module
Status:needs work» needs review

Rerolled and changed variable_set('site_frontpage', 'node') to variable_set('site_frontpage', 'user').

AttachmentSizeStatusTest resultOperations
remove-node-from-minimal-1370708-2.patch962 bytesIdlePASSED: [[SimpleTest]]: [MySQL] 34,610 pass(es).View details | Re-test

#3

Component:profile.module» install system

I'm pretty certain that profile.module refers to the Profile module.

Doesn't appear like there are components for the Core install profiles.

#4

Problem.
Applied patch (cleanly) onto clean checkout.
On running a new install (in a multisite) I got the following error at step "Install profile".

The installation has encountered an error.
Please continue to the error page

An AJAX HTTP error occurred. HTTP Result Code: 200 Debugging information follows. Path: http://minimal.drupal8.gadget/core/install.php?langcode=en&profile=minim... StatusText: OK ResponseText: User account | Drupal @import url("http://minimal.drupal8.gadget/core/modules/system/system.base.css?0"); @import url("http://minimal.drupal8.gadget/core/modules/system/system.theme.css?0"); @import url("http://minimal.drupal8.gadget/core/modules/field/theme/field.css?0"); @import url("http://minimal.drupal8.gadget/core/modules/user/user.css?0"); @import url("http://minimal.drupal8.gadget/core/modules/system/system.admin.css?0"); @import url("http://minimal.drupal8.gadget/core/modules/system/system.maintenance.css?0"); @import url("http://minimal.drupal8.gadget/core/themes/seven/reset.css?0"); @import url("http://minimal.drupal8.gadget/core/themes/seven/style.css?0"); User account Installation tasksChoose language(done)Choose profile(done)Verify requirements(done)Set up database(done)Install profile(active)Configure siteFinished SQLSTATE[23000]: Integrity constraint violation: 1048 Column 'module' cannot be null

I'm reviewing now to isolate that this isn't a problem from my end or something odd, but right now it looks dodgy.

#5

Status:needs review» needs work

Yeah, I can confirm this kills things.