We belatedly updated to use facebook's PHP SDK v3.1 today, and found a few problems that were because the signed request from Facebook was not passed through to the PHP SDK.

The attached patch fixes this.

CommentFileSizeAuthor
fb-signed-request.patch672 bytesjames.williams

Comments

ianthomas_uk’s picture

ianthomas_uk
he/him
Primary language English
Location Brighton, UK
commented
Status: Active » Reviewed & tested by the community

This patch works for me

ianthomas_uk’s picture

ianthomas_uk
he/him
Primary language English
Location Brighton, UK
commented
Status: Reviewed & tested by the community » Needs work

This patch no longer applies because code round about it has changed, but given the patch has been sitting in the issue queue for the best part of a year I'm not sure if it is still needed or not. Can anyone who knows the API better advise?

Dave Cohen’s picture

Dave Cohen commented

I'm not sure what the original problems were. If a change like this is needed, somebody please explain in detail. I don't think it's needed.

james.williams’s picture

james.williams
Location Coventry, UK
commented

We are still using the patch in our builds, but we're also using an old dev version of the module, as that's what we have tested fully for our purposes. It does look like the signed request is now handled elsewhere in the code of the latest dev version, so perhaps it isn't needed any more. BUT I haven't tested that latest code against our builds so I can't say for certain.

@ianmthomasuk - that probably means you'll have to do some testing to know for sure.

I don't know exactly what the problems we encountered were, but I expect they were something to do with that specific version of the FB module. Here's what I wrote on our internal ticket for our client, which unfortunately isn't very technical/specific:

This is what ought to be fixed:
- facebook communicating with our app(s) which it had stopped doing today.
- registering & using fbconnect
- pulling in details for users such as name and photo