Closed (fixed)
Project:
SimpleAds
Version:
7.x-1.5
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Reporter:
Created:
14 Dec 2011 at 21:11 UTC
Updated:
15 Dec 2011 at 13:27 UTC
Ads do not display while using Internet Explorer. This is true for all user types (administrator...authenticated user...anonymous user).
Comments
Comment #1
jboese commentedit looks like for IE it is required for each block to provide the width and height for the advertisement, even though the module does not require these fields.
I originally chose to left this blank, as I don't like stretching ads smaller than this specification to fit the space as the SimpleAds module does...
Comment #2
jboese commentedBased on how this module assigns img width and height values, and how IE interprets them, i propose a patch to simpleads_img_element.tpl.php that does the following:
-<img src="<?php print $ad['image']; ?>" alt="<?php print check_plain($ad['alt']); ?>" width="<?php print check_plain($settings['ads_width']); ?>" height="<?php print check_plain($settings['ads_height']); ?>" border="0">+<img src="<?php print $ad['image']; ?>" alt="<?php print check_plain($ad['alt']); ?>" <?php if ($settings['ads_width']){?>width="<?php print check_plain($settings['ads_width']); ?>"<?php } ?> <?php if ($settings['ads_height']) { ?>height="<?php print check_plain($settings['ads_height']); ?>"<?php } ?> border="0">(Sorry about this. I haven't activated Git access yet. Doing that now :))
Comment #3
minnur commented@jboese, thanks for finding this issue. I will fix it as soon as it possible. Most likely this weekend.
For the time being you may copy template file to your theme and modify it the way you want.
Comment #4
minnur commentedComment #5
minnur commentedComment #6
minnur commentedComment #7
minnur commented@jboese, This is fixed. Please download version 7.x-1.6 and run update.php
Comment #8
minnur commentedComment #9
jboese commentedThanks so much for your work on this module!