Problem with Quotes in titles, solved with one simple line [#1371934]

Hi all,

If you have custom breadcrumb titles of nodes that have quotes (" "), they are represented with the html characters "

To solve this, go to custom_breadcrumb.module, and add this line

$title = str_replace('"', '"', $title);

Before this one
$trail[] = _custom_breadcrumbs_create_crumb($title, $path);

Greetings

Comments

Comment #1

msmithcti commented 3 January 2012 at 09:12

Thanks for posting this solution - I needed a few more strings replacing so used the following code:

$search = array('&quot;', '&amp;', '&#039;');
$replace   = array('"', '&', "'");
$title = str_replace($search, $replace, $title);

In the same place as above.

I'm not sure this is the best solution - is there a reason quotes etc. are being replaced by their HTML entity codes in the first place?

Comment #2

lemming commented 15 May 2012 at 15:12

This issue is also related to and resovled here (with a broader fix):

http://drupal.org/node/1446350

I also recommend avoiding the numerous fixes that encourage you to just decode the outputted result.

It is inefficient. You run HTML twice, and then run decode to undo one of the last encoding.
It does not cover cases where explicit text (non-tokens) are used. Items not processed with token replace have only been encoded once. Decoding them undoes any HTML escape sequences.

Comment #3

lemming commented 15 May 2012 at 15:55

I retract some of point #2, I've seen some suggestions where the call to decode HTML occurs before the 2nd encoding call, which should handle these cases correctly.