Closed (fixed)
Project:
Zen
Version:
7.x-5.x-dev
Component:
CSS/SASS/HTML markup
Priority:
Major
Category:
Feature request
Assigned:
Unassigned
Reporter:
Created:
15 Dec 2011 at 17:17 UTC
Updated:
14 Apr 2012 at 01:41 UTC
Jump to comment: Most recent file
Comments
Comment #1
echoz commentedIs this a duplicate of #1295296: Add HTML5 display definitions from D8 and normalize.css ? Not marking as dupe yet, but asking... is there anything else Zen doesn't already cover beyond what we added here? As I posted, "and perhaps other smart stuff", noting normalize.css and html5boilerplate using it. I also am delighted with Drupal devs on the same page with the dev community at large.
Comment #2
maartenverbaarschot commentedI was thinking more along the lines of taking normalize.css to replace html-reset.css, tweaking it specifically for Drupal, and then check if there's any stuff left from the current html-reset that needs to stay.
I like how normalize.css focuses on just providing a good starting point with consistent browser defaults, with almost zero presentational bulk since most people want to write those themselves anyway.
Also, using work "as is" from the H5BP community would allow us to focus more on the Drupal side of things :)
Comment #3
echoz commentedI was thinking similarly when I proposed the referenced issue, as I do really like normalize.css and how html5boilerplate adapted it. As I compared, it seemed the HTML5 display definitions were the significant part lacking in zen, and like you, proposed it without a patch to see how John wanted to integrate it. It just flowed into what D8 had done. Let’s see what John thinks.
Comment #4
johnalbinI like it!
Let's do this now!
Comment #5
KrisBulman commentedwicked, glad to see this happening.
Comment #6
johnalbinI converted normalize to SCSS over in https://github.com/JohnAlbin/normalize.css if anyone wants to use that as a basis for a patch.
Comment #7
johnalbinOn second though, I just went and added normalize.scss to zen/STARTERKIT/sass/. I haven't linked it in via the .info file and it still needs to be merged with html-elements.scss. But that should make the patch easier to make.
Comment #8
johnalbinI've postponed #1440910: Change font styling technique from "em"s to "rem"s and #1439712: Add default variables for use in sass files until this issue is complete.
Comment #9
johnalbinI now have a "drupalized" normalize over at https://github.com/JohnAlbin/normalize.css/tree/drupal-normalize
Updated Zen to use that.
Comment #10
KrisBulman commentedI suggest we remove the star hacks in this file for targetting ie6-7 with:
example:
before
after:
output:
Comment #11
echoz commentedAnother step towards using normalize.css, this further readies normalize.scss replacing hacks with ie conditional classes. @KrisBulman, thanks for the nudge, as I was already working on this. The patch caught one trailing whitespace also.
Comment #12
johnalbinI completed porting normalize to Compass over at https://github.com/JohnAlbin/normalize.css-with-sass-or-compass
And then completed porting it to Drupal over at http://drupal.org/project/normalize
Elly, I committed your patch to a feature branch, 1372040-normalize. I need to think about that one. It bumps up the specificity on html elements in IE.
Now I just need to merge html-elements into normalize on the plane. Leaving for Drupalcon in an hour.
Comment #13
johnalbinIn the end, I decided to keep the star hacks because it is what is in the Normalize with Compass project. It will make maintenance a little easier. As well as keep the specificity lower.
I've finished merging in all the html-elements stuff into normalize.
Fixed. http://drupalcode.org/project/zen.git/commitdiff/6451c0a
Comment #14
johnalbinI should note that our normalize doesn't contain empty rulesets for every HTML5 element like our old html-elements did. That decision follows along with what the standard normailze does. Though, I made an exception to have empty rulesets for links since the ordering of the link pseudo-selectors is important.