The javascript in gigya_sharebar.js does not conform to Drupal JavaScript best practices (http://drupal.org/node/756722#behaviors) and use jQuery(document).ready() instead of Drupal.behaviors for adding functionality to the page. This causes errors if content is added/replaced via AJAX or other means on the page other than a normal browser page load.

This code should be refactored to use Drupal.behaviors appropriately.

CommentFileSizeAuthor
#3 gigya-drupal-behaviors-1372104-3.patch1.95 KBcameron tod
#1 use_drupal_behaviors-1372104-1.patch2.67 KBbmcmurray

Comments

bmcmurray’s picture

bmcmurray commented
StatusFileSize
new use_drupal_behaviors-1372104-1.patch2.67 KB

Attached is a patch which reworks the JavaScript of gigya_sharebar.js to use a Drupal.behavior properly.

ericduran’s picture

ericduran commented
Status: Active » Reviewed & tested by the community

Not much to say. We probably should add a detach method but thats not there now. So this is good too.

cameron tod’s picture

cameron tod commented
StatusFileSize
new gigya-drupal-behaviors-1372104-3.patch1.95 KB

Here's a patch which updates gigya_comments.js to use Drupal.behaviors.

gambaweb’s picture

gambaweb commented
Status: Reviewed & tested by the community » Closed (fixed)

@cam8001 thanks for that committed to dev