Posted by axel.rutz on December 15, 2011 at 11:55pm
8 followers
| Project: | Commerce Coupon |
| Version: | 7.x-1.x-dev |
| Component: | Code |
| Category: | feature request |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | closed (fixed) |
Issue Summary
i think this would give a better dx with cleaner modules to start with.
or do many people want a combined-fixed-plus-variable coupon?
Comments
#1
battle plan:
* copy basic_coupon to fixed_coupon and percentage_coupon
(leave basic coupon for a smooth upgrade)
* get the names of the functions right
* throw out in each of the two new modules what isn't needed
#2
+1 to this
#3
Working on it. I'm separating the fixed and percentage coupons in two modules.
http://drupal.org/sandbox/pcambra/1454380
http://drupal.org/sandbox/pcambra/1454390
And patch attached to standarize
#4
Pushed refresh support for fixed amounts and also one component price per coupon when fixed.
#5
Rebased against latest head.
#6
Little tweaks after fixing active flag
#7
Finished the upgrade path from basic coupons to fixed/percentage
I was going to promote the sandboxes to full projects and committing this but had some strange problem: []
Attaching the latest patch.
#8
@pcambra -- sorry haven't reviewed your patches yet but I'm looking forward to this. You mentioned promoting sandbox projects. Do you envision the fixed/percentage coupons be available only as separate projects, or rolled into "contrib" modules in this project?
#9
Oops, I forgot to paste the issue reference #1483876: Promoted full projects merged
As soon as that one gets resolved, I'll promote fixed and pct as independent projects and commit all this together.
#10
Answering more clearly, there won't be a contrib folder anymore on this project, same as shipping.
#11
And commited!
#12
cool you dunnit!
(i'm so stuck in other projects, but cant await to check it out.)
#13
Thanks pcambra. Can't wait to try this out!
#14
@Pcambra: thanks a lot. i use a heavily patched version at the moment and it still has some flaws. Is the current dev release usable for percentage and fixed coupons?
#15
Absolutely, last -dev doesn't have either pct coupons or fixed amount ones, you'll need the those new modules to get something working :)
#16
Automatically closed -- issue fixed for 2 weeks with no activity.
#17
Is there an upgrade path? What happens to current coupons if you use start using the new, separated modules instead of the old combined one?
#18
Yes, you'll find an upgrade form in the Settings screen of commerce coupon